Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8237: Add support for Jolokia over Kubernetes proxy #576

Draft
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

skarsaune
Copy link
Contributor

@skarsaune skarsaune commented Aug 4, 2024

JMC-8273 : Use the jolokia protocol over a kubernetes http proxy.

Testing connectivity:

  • Docker desktop kubernetes
  • Azure AKS
  • Amazon EKS
  • Google GKE

Other things observed:

  • * Option to install agent should be disabled (debug difference with jolokia) - see below*
  • * Warning: NLS missing message: JmcKubernetesPreferenceForm_LogErrorsTooltip in: org.openjdk.jmc.kubernetes.preferences.messages
  • * SLF4J(W): No SLF4J providers were found. OK for now, can investigate more later
    SLF4J(W): Defaulting to no-operation (NOP) logger implementation
    SLF4J(W): See https://www.slf4j.org/codes.html#noProviders for further details.
  • Unlocking secrets now appear on startup. Should not be needed unless there are credentials used. (fixed)

Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JMC-8237: Add support for Jolokia over Kubernetes proxy (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/576/head:pull/576
$ git checkout pull/576

Update a local copy of the PR:
$ git checkout pull/576
$ git pull https://git.openjdk.org/jmc.git pull/576/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 576

View PR using the GUI difftool:
$ git pr show -t 576

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/576.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 4, 2024

👋 Welcome back skarsaune! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 4, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@skarsaune skarsaune changed the title JMC-8237: Connect with Jolokia protocol over kubernetes HTTP proxy JMC-8237: Connect with Jolokia protocol over kubernetes proxy Aug 9, 2024
@skarsaune skarsaune changed the title JMC-8237: Connect with Jolokia protocol over kubernetes proxy JMC-8237: Add support for Jolokia over Kubernetes proxy Aug 9, 2024
@openjdk openjdk bot changed the title JMC-8237: Add support for Jolokia over Kubernetes proxy 8237: Add support for Jolokia over Kubernetes proxy Aug 9, 2024
@thegreystone thegreystone requested a review from aptmac September 25, 2024 17:10
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 29, 2024

@skarsaune This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@skarsaune
Copy link
Contributor Author

The cause for the log initialization output is calling Utils.getSystemPropertyOrEnvVar . That is only used very briefly for that very particular use. Can look for alternatives.

@skarsaune
Copy link
Contributor Author

The cause for the log initialization output is calling Utils.getSystemPropertyOrEnvVar . That is only used very briefly for that very particular use. Can look for alternatives.

However, other fabric8.io methods need slf4j quite immediately after that. As the log statement states, it will default to a NOOP logger that we believe is sufficient at this point (problems scanning contexts will manifest themselves as exceptions that should be sufficient to troubleshoot).

@skarsaune
Copy link
Contributor Author

Found the "issue" with the JMC agent.

public boolean isLocalJvm() { return connectionHandle.getServerDescriptor().getJvmInfo() != null; }
Will experiment with not providing getJvmInfo for jolokia and kubernetes

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 24, 2024

@skarsaune This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant