-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8237: Add support for Jolokia over Kubernetes proxy #576
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back skarsaune! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This reverts commit c81c035.
@skarsaune This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
The cause for the log initialization output is calling |
However, other fabric8.io methods need slf4j quite immediately after that. As the log statement states, it will default to a NOOP logger that we believe is sufficient at this point (problems scanning contexts will manifest themselves as exceptions that should be sufficient to troubleshoot). |
Found the "issue" with the JMC agent.
|
@skarsaune This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
JMC-8273 : Use the jolokia protocol over a kubernetes http proxy.
Testing connectivity:
Other things observed:
SLF4J(W): Defaulting to no-operation (NOP) logger implementation
SLF4J(W): See https://www.slf4j.org/codes.html#noProviders for further details.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/576/head:pull/576
$ git checkout pull/576
Update a local copy of the PR:
$ git checkout pull/576
$ git pull https://git.openjdk.org/jmc.git pull/576/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 576
View PR using the GUI difftool:
$ git pr show -t 576
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/576.diff