-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8299: JDP Tests in core fail if multicast is not possible #611
Conversation
👋 Welcome back skarsaune! A progress list of the required criteria for merging this PR into |
@skarsaune This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 7 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
Hi, @skarsaune. You need to create/reference another bug but not JMC-7539 since that one is already closed. |
@skarsaune This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
/integrate |
@skarsaune |
/sponsor |
Going to push as commit a888d01.
Your commit was automatically rebased without conflicts. |
@RealCLanger @skarsaune Pushed as commit a888d01. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
As
Now reside in common, installCore should skip JDP multicast test when the build file has been called with the flag to avoid JDP multicast tests
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/611/head:pull/611
$ git checkout pull/611
Update a local copy of the PR:
$ git checkout pull/611
$ git pull https://git.openjdk.org/jmc.git pull/611/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 611
View PR using the GUI difftool:
$ git pr show -t 611
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/611.diff
Using Webrev
Link to Webrev Comment