Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8299: JDP Tests in core fail if multicast is not possible #611

Closed
wants to merge 1 commit into from

Conversation

skarsaune
Copy link
Contributor

@skarsaune skarsaune commented Nov 24, 2024

As

JDPClientTest.testChangePacket:95
JDPClientTest.testJDPClient:73
JDPJMXTest.testJDPClient:71

Now reside in common, installCore should skip JDP multicast test when the build file has been called with the flag to avoid JDP multicast tests


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JMC-8299: JDP Tests in core fail if multicast is not possible (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/611/head:pull/611
$ git checkout pull/611

Update a local copy of the PR:
$ git checkout pull/611
$ git pull https://git.openjdk.org/jmc.git pull/611/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 611

View PR using the GUI difftool:
$ git pr show -t 611

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/611.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 24, 2024

👋 Welcome back skarsaune! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 24, 2024

@skarsaune This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299: JDP Tests in core fail if multicast is not possible

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 9725f58: 8310: Fix connections over RMI and Jolokia - undo rjmx change for 8287
  • 77713a0: 8303: NPE at org.openjdk.jmc.flightrecorder.rules.report.JfrRulesReport.addReport
  • 39a795d: 8306: Missing plugins while installing JMC 9.1.0 in Eclipse IDE
  • b149c36: 8296: No Java process should ever be PID 1
  • dc54462: 8300: Update to Eclipse 2024-12
  • 254d795: 8295: Shutdown event type id is not properly translated for Oracle JDK 8
  • cbf7349: 8298: Update to Eclipse 2024-09

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the rfr label Nov 24, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 24, 2024

Webrevs

@RealCLanger
Copy link
Collaborator

Hi, @skarsaune. You need to create/reference another bug but not JMC-7539 since that one is already closed.

@skarsaune skarsaune changed the title JMC-7539: Ensure installCore respects avoiding JDP tests JMC-8299: JDP Tests in core fail if multicast is not possible Nov 28, 2024
@openjdk openjdk bot changed the title JMC-8299: JDP Tests in core fail if multicast is not possible 8299: JDP Tests in core fail if multicast is not possible Nov 28, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 23, 2024

@skarsaune This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@openjdk openjdk bot added the ready label Jan 11, 2025
@skarsaune
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor label Jan 11, 2025
@openjdk
Copy link

openjdk bot commented Jan 11, 2025

@skarsaune
Your change (at version effb0e4) is now ready to be sponsored by a Committer.

@RealCLanger
Copy link
Collaborator

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 11, 2025

Going to push as commit a888d01.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 9725f58: 8310: Fix connections over RMI and Jolokia - undo rjmx change for 8287
  • 77713a0: 8303: NPE at org.openjdk.jmc.flightrecorder.rules.report.JfrRulesReport.addReport
  • 39a795d: 8306: Missing plugins while installing JMC 9.1.0 in Eclipse IDE
  • b149c36: 8296: No Java process should ever be PID 1
  • dc54462: 8300: Update to Eclipse 2024-12
  • 254d795: 8295: Shutdown event type id is not properly translated for Oracle JDK 8
  • cbf7349: 8298: Update to Eclipse 2024-09

Your commit was automatically rebased without conflicts.

@openjdk
Copy link

openjdk bot commented Jan 11, 2025

@RealCLanger @skarsaune Pushed as commit a888d01.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants