Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8341759: [lworld] JIT support for nullable, atomic, flat fields #1318

Draft
wants to merge 35 commits into
base: lworld
Choose a base branch
from

Conversation

TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Dec 16, 2024

WIP


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8341759: [lworld] JIT support for nullable, atomic, flat fields (Enhancement - P2)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1318/head:pull/1318
$ git checkout pull/1318

Update a local copy of the PR:
$ git checkout pull/1318
$ git pull https://git.openjdk.org/valhalla.git pull/1318/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1318

View PR using the GUI difftool:
$ git pr show -t 1318

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1318.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 16, 2024

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 16, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@TobiHartmann TobiHartmann changed the title 8341759: [lworld] JIT getfield/putfield for new flat fields on x64 and aarch64 8341759: [lworld] JIT support for nullable, atomic, flat fields Dec 20, 2024
@openjdk
Copy link

openjdk bot commented Dec 20, 2024

@TobiHartmann this pull request can not be integrated into lworld due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout JDK-8341759
git fetch https://git.openjdk.org/valhalla.git lworld
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge lworld"
git push

@openjdk openjdk bot removed the merge-conflict label Dec 20, 2024
@openjdk openjdk bot removed the merge-conflict label Jan 15, 2025
@openjdk openjdk bot removed the merge-conflict label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant