Avoid external connections in specs

openjournals · Apr 29, 2024 · 58ad16d · 58ad16d
1 parent 546f86b
commit 58ad16d
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 3 deletions.
diff --git a/spec/controllers/editors_controller_spec.rb b/spec/controllers/editors_controller_spec.rb
@@ -60,7 +60,7 @@
       get :index
 
       expect(@controller.view_assigns["active_editors"]).to eq([current_user.editor, board, editor])
-      expect(@controller.view_assigns["emeritus_editors"]).to eq([emeritus])
+      expect(@controller.view_assigns["emeritus_editors"].to_a).to eq([emeritus])
     end
 
     it "assigns grouped availability information" do

diff --git a/spec/system/papers/search_papers_spec.rb b/spec/system/papers/search_papers_spec.rb
@@ -2,6 +2,7 @@
 
 feature "Paper search" do
   before do
+    skip_paper_repo_url_check
     paper_1 = create(:accepted_paper, title: "Astronomy paper")
     paper_1.metadata['paper']['title'] = "Astronomy paper"
     paper_1.metadata['paper']['authors'] = [{'given_name' => "Vera", 'last_name' => "Rubin"}]

diff --git a/spec/system/papers/show_published_spec.rb b/spec/system/papers/show_published_spec.rb
@@ -2,6 +2,7 @@
 
 feature "Published paper's show page" do
   before do
+    skip_paper_repo_url_check
     @accepted_paper = create(:accepted_paper, title: "Astronomy paper", doi: "10.21105/joss.00001", review_issue_id: 1)
     @accepted_paper.metadata['paper']['title'] = "Astronomy paper"
     @accepted_paper.metadata['paper']['authors'] = [{'given_name' => "Vera", 'last_name' => "Rubin"}]

diff --git a/spec/system/papers/track_info_spec.rb b/spec/system/papers/track_info_spec.rb
@@ -3,15 +3,15 @@
 feature "Paper's track info" do
   feature "When tracks feature is enabled" do
     before do
-      skip_paper_repo_url_check
       allow(Repository).to receive(:editors).and_return(["@editor_1", "@editor_2"])
+      skip_paper_repo_url_check
+      @paper = create(:paper)
     end
 
     around do |ex|
       enable_feature(:tracks) do
         @track_1 = create(:track, name: "Astrophysics", short_name: "ASTRO", code: "42")
         @track_2 = create(:track, name: "Biology", short_name: "BIO", code: "34")
-        @paper = create(:paper)
 
         ex.run
       end
@@ -36,6 +36,7 @@
 
     feature "Logged as an admin" do
       before do
+        skip_paper_repo_url_check
         @aeic = create(:admin_user, editor: create(:board_editor))
         @track = create(:track, name: "Testing track", short_name: "TE", code: "33")
         login_as(@aeic)

diff --git a/spec/system/toc_spec.rb b/spec/system/toc_spec.rb
@@ -2,6 +2,8 @@
 
 feature "Table of Contents" do
   before do
+    skip_paper_repo_url_check
+
     parsed_launch_date = Time.parse(Rails.application.settings[:launch_date])
     @launch_year = parsed_launch_date.year
     @launch_month = parsed_launch_date.month