-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1264 add project contribution to checklist #1265
Merged
tobie
merged 2 commits into
openjs-foundation:main
from
bensternthal:add-participation-agreement
Mar 11, 2024
Merged
Fix #1264 add project contribution to checklist #1265
tobie
merged 2 commits into
openjs-foundation:main
from
bensternthal:add-participation-agreement
Mar 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobie
approved these changes
Mar 1, 2024
ljharb
approved these changes
Mar 1, 2024
anonrig
approved these changes
Mar 2, 2024
mcollina
approved these changes
Mar 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
mhdawson
approved these changes
Mar 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Added link to contribution agreement. Signed-off-by: Benjamin Sternthal <[email protected]>
ljharb
force-pushed
the
add-participation-agreement
branch
from
March 8, 2024 17:00
a10960d
to
eb5b16a
Compare
WaleedAshraf
approved these changes
Mar 11, 2024
bensternthal
added a commit
to bensternthal/cross-project-council
that referenced
this pull request
Apr 23, 2024
…njs-foundation#1265) Signed-off-by: Benjamin Sternthal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1264, note when this is merged I will update https://github.com/openjs-foundation/project-status/blob/HEAD/.github/ISSUE_TEMPLATE/00-project-onboarding-checklist-template.md
Note the project contribution agreement is the legal document that actually transfers the accounts, trademarks and limited power of attorney to the foundation.