Setup upgrade #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Upgrade the setuptools backend - Remove tests from the distribution
- Make kim_edn.tool read infile before writing to outfile so that `python -m kim_edn.tool foo.edn foo.edn` doesn't result in an empty foo.edn.
- Open and close files manually. It prevents from leaking files, preliminary creation of output files, and accidental closing of stdin and stdout.
- Update the load and loads interface. Remove parse_constant which is not used in kim-edn. - Update the loads interface. Now it can accept the Decoder object
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes,
pyproject.tomlhinting build tools likepip&buildwhich backend to use>= 3.8, although there should be no issue using lower Python version of3.7.load&loadsinterfaces and remove unused argumentparse_constantloadsinterface to accept a Decoder object. The object can be built with strict as Falsekim_edn.KIMEDNDecoder(strict=False)kim_edn.toolinterfaceappveyorsupport. Now, GitHub action will cover Linux, Macs, and Windowstest_toolto coverkim_edn.toolmambainstallation instruction