Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add docs generation for kruise #98

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Conversation

maanugh
Copy link
Contributor

@maanugh maanugh commented Aug 11, 2024

No description provided.

Copy link
Member

@hantmac hantmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job. LGTM!

docs/kubectl-kruise.md Show resolved Hide resolved
docs/kubectl-kruise.md Outdated Show resolved Hide resolved
@hantmac
Copy link
Member

hantmac commented Aug 13, 2024

@maanugh Hi, we has no need to add the exec, apply and some other cmds. We only include the cmds which in kubectl-kruise plugin.

Copy link
Member

@hantmac hantmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maanugh Hi, we has no need to add the exec, apply and some other cmds. We only include the cmds which in kubectl-kruise plugin.

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign fillzpp for approval by writing /assign @fillzpp in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@maanugh
Copy link
Contributor Author

maanugh commented Aug 13, 2024

got it.

@maanugh
Copy link
Contributor Author

maanugh commented Aug 16, 2024

Removed commands: exec, apply, wait, diff, options, help, api-resources, api-versions, patch, plugin, scale, replace, kustomize, version, config, completion

@hantmac hantmac merged commit cfd9de2 into openkruise:master Sep 19, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants