SidecarSet add upgrade state in pod annotation #1349

xiangpingjiang · 2023-07-28T06:04:11Z

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

sonatype-lift · 2023-07-28T06:04:14Z

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

codecov-commenter · 2023-07-28T06:14:42Z

Codecov Report

Attention: Patch coverage is 38.70968% with 57 lines in your changes missing coverage. Please review.

Project coverage is 49.87%. Comparing base (4e35a1d) to head (40103b6).
Report is 119 commits behind head on master.

Files	Patch %	Lines
pkg/control/sidecarcontrol/util.go	2.63%	37 Missing ⚠️
pkg/controller/sidecarset/sidecarset_processor.go	57.44%	16 Missing and 4 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1349      +/-   ##
==========================================
+ Coverage   48.60%   49.87%   +1.26%     
==========================================
  Files         152      160       +8     
  Lines       21333    24759    +3426     
==========================================
+ Hits        10369    12348    +1979     
- Misses       9828    11172    +1344     
- Partials     1136     1239     +103

Flag	Coverage Δ
unittests	`49.87% <38.70%> (+1.26%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kruise-bot · 2023-08-04T17:17:30Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zmberg for approval by writing /assign @zmberg in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

pkg/control/sidecarcontrol/util.go

Signed-off-by: pingjiang <[email protected]>

hantmac · 2023-08-21T03:11:34Z

pkg/controller/sidecarset/sidecarset_processor.go

@@ -103,6 +103,13 @@ func (p *Processor) UpdateSidecarSet(sidecarSet *appsv1alpha1.SidecarSet) (recon
 		return reconcile.Result{RequeueAfter: time.Second}, nil
 	}

+	// check if pod finish sidecar container upgrade
+	for _, pod := range pods {


Maybe we should make updatePodsSidecarHashState after line-99 because some pods that already ready should be update state to Noamal.

hantmac · 2023-08-21T03:12:22Z

pkg/controller/sidecarset/sidecarset_processor.go

@@ -189,6 +196,53 @@ func (p *Processor) updatePods(control sidecarcontrol.SidecarControl, pods []*co
 	return nil
 }

+func (p *Processor) updatePodSidecarHashState(control sidecarcontrol.SidecarControl, pod *corev1.Pod) error {


Need some e2e tests?

stale · 2023-11-19T04:46:59Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

xiangpingjiang · 2023-11-27T02:06:56Z

/open

stale · 2024-06-07T04:00:29Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

kruise-bot requested review from Fei-Guo and zmberg July 28, 2023 06:04

kruise-bot added the size/L size/L: 100-499 label Jul 28, 2023

xiangpingjiang force-pushed the sidecarSet_pod_annotation branch from c160ae1 to 4622ead Compare July 28, 2023 06:11

xiangpingjiang force-pushed the sidecarSet_pod_annotation branch from 4622ead to 370b32b Compare July 28, 2023 06:17

xiangpingjiang force-pushed the sidecarSet_pod_annotation branch from 370b32b to 8d6f847 Compare August 4, 2023 17:17

xiangpingjiang force-pushed the sidecarSet_pod_annotation branch from 8d6f847 to 5088706 Compare August 4, 2023 22:55

hantmac reviewed Aug 20, 2023

View reviewed changes

pkg/control/sidecarcontrol/util.go Outdated Show resolved Hide resolved

xiangpingjiang marked this pull request as draft August 20, 2023 02:04

kruise-bot added the do-not-merge/work-in-progress label Aug 20, 2023

xiangpingjiang force-pushed the sidecarSet_pod_annotation branch from 5a14574 to 07b34d5 Compare August 20, 2023 02:59

kruise-bot added size/M size/M: 30-99 size/L size/L: 100-499 and removed size/L size/L: 100-499 size/M size/M: 30-99 labels Aug 20, 2023

xiangpingjiang force-pushed the sidecarSet_pod_annotation branch from ea1ad54 to 2961add Compare August 20, 2023 06:57

kruise-bot added size/M size/M: 30-99 and removed size/L size/L: 100-499 labels Aug 20, 2023

xiangpingjiang force-pushed the sidecarSet_pod_annotation branch from d1cebb0 to 7c808cf Compare August 20, 2023 14:12

kruise-bot added size/L size/L: 100-499 and removed size/M size/M: 30-99 labels Aug 20, 2023

xiangpingjiang marked this pull request as ready for review August 20, 2023 14:16

kruise-bot removed the do-not-merge/work-in-progress label Aug 20, 2023

kruise-bot requested a review from FillZpp August 20, 2023 14:16

xiangpingjiang requested a review from hantmac August 20, 2023 14:16

xiangpingjiang marked this pull request as draft August 20, 2023 15:12

kruise-bot added the do-not-merge/work-in-progress label Aug 20, 2023

SidecarSet add upgrade state in pod annotation

40103b6

Signed-off-by: pingjiang <[email protected]>

xiangpingjiang force-pushed the sidecarSet_pod_annotation branch from 7c808cf to 40103b6 Compare August 20, 2023 15:13

xiangpingjiang marked this pull request as ready for review August 20, 2023 15:50

kruise-bot removed the do-not-merge/work-in-progress label Aug 20, 2023

kruise-bot requested a review from furykerry August 20, 2023 15:50

hantmac reviewed Aug 21, 2023

View reviewed changes

stale bot added the wontfix This will not be worked on label Nov 19, 2023

stale bot closed this Nov 26, 2023

zmberg reopened this Mar 7, 2024

stale bot removed the wontfix This will not be worked on label Mar 7, 2024

stale bot added the wontfix This will not be worked on label Jun 7, 2024

stale bot closed this Jun 15, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SidecarSet add upgrade state in pod annotation #1349

SidecarSet add upgrade state in pod annotation #1349

xiangpingjiang commented Jul 28, 2023

sonatype-lift bot commented Jul 28, 2023

codecov-commenter commented Jul 28, 2023 •

edited by codecov bot

Loading

kruise-bot commented Aug 4, 2023

hantmac Aug 21, 2023

hantmac Aug 21, 2023

stale bot commented Nov 19, 2023

xiangpingjiang commented Nov 27, 2023

stale bot commented Jun 7, 2024

SidecarSet add upgrade state in pod annotation #1349

SidecarSet add upgrade state in pod annotation #1349

Conversation

xiangpingjiang commented Jul 28, 2023

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

sonatype-lift bot commented Jul 28, 2023

Sonatype Lift is retiring

codecov-commenter commented Jul 28, 2023 • edited by codecov bot Loading

Codecov Report

kruise-bot commented Aug 4, 2023

hantmac Aug 21, 2023

Choose a reason for hiding this comment

hantmac Aug 21, 2023

Choose a reason for hiding this comment

stale bot commented Nov 19, 2023

xiangpingjiang commented Nov 27, 2023

stale bot commented Jun 7, 2024

codecov-commenter commented Jul 28, 2023 •

edited by codecov bot

Loading