Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some retries when getObjectOf pod's owner #1807

Merged

Conversation

AiRanthem
Copy link
Member

  1. add some retries when getObjectOf pod's owner
  2. prevent WorkloadSpre…ad e2e panic

Ⅰ. Describe what this PR does

Fixes a potential bug of WorkloadSpread

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. Describe how to verify it

run the elastic deploy for deployment, zone-a=2, zone-b=nil e2e test very lots of times

Ⅳ. Special notes for reviews

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.00%. Comparing base (0d0031a) to head (0506db2).
Report is 112 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1807      +/-   ##
==========================================
+ Coverage   47.91%   50.00%   +2.09%     
==========================================
  Files         162      192      +30     
  Lines       23491    24634    +1143     
==========================================
+ Hits        11256    12319    +1063     
- Misses      11014    11038      +24     
- Partials     1221     1277      +56     
Flag Coverage Δ
unittests 50.00% <100.00%> (+2.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AiRanthem AiRanthem force-pushed the bug/ws-get-owner-object-failed-241028 branch 2 times, most recently from cb3007a to 158b4ad Compare October 29, 2024 07:30
Copy link
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

…` pod's owner failed; prevent WorkloadSpread e2e panic

Signed-off-by: AiRanthem <[email protected]>
@AiRanthem AiRanthem force-pushed the bug/ws-get-owner-object-failed-241028 branch from 158b4ad to 0506db2 Compare October 31, 2024 05:46
@zmberg zmberg merged commit c426ed9 into openkruise:master Oct 31, 2024
43 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants