coupon update delegate key #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #604 +/- ##
==========================================
+ Coverage 90.68% 90.75% +0.07%
==========================================
Files 54 55 +1
Lines 1964 1979 +15
Branches 452 454 +2
==========================================
+ Hits 1781 1796 +15
Misses 183 183 ☔ View full report in Codecov by Sentry. |
nickmzero
previously approved these changes
Oct 15, 2024
| } | ||
|
|
||
| /** | ||
| * @notice Redeems a coupon to burn tokens |
There was a problem hiding this comment.
This line should be updated
jdville03
reviewed
Oct 16, 2024
| ); | ||
|
|
||
| /** | ||
| * @notice Configures the Adapter with the coupon signer address and token to burn. |
There was a problem hiding this comment.
Global comment - can you go through and update the comments?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes