Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optionally use POST insetad of GET for WMSGetFeatureInfo - trac ticket 3357 #1507

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bkiselka
Copy link
Contributor

@bkiselka bkiselka commented Nov 22, 2016

add option usePOST for optionally using POST instead of GET for WMSGetFeatureInfo requests (idea from Protocol/HTTP.js)

fixes https://trac.osgeo.org/openlayers/ticket/3357

@ahocevar
Copy link
Member

You decided to reuse layers, but not wmsOptions? A bonus would be to make this consistent and reuse both.

Also, what happens when using drillDown with POST? I think the change would be clearer if you added unit tests.

@bkiselka
Copy link
Contributor Author

I must admit, I did only tested the this.drillDown === false section.
Though I think it should work, I'll add some unit tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants