A11y structure css updates #15
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauromsl
reviewed
Jul 11, 2025
Comment on lines
15
to
16
| ('olh', '#content aside', '#content .side-info'), | ||
| ('olh', '#content aside h3', '#content aside h2'), |
There was a problem hiding this comment.
be mindful of having some entries as substrings of one another. In this case, we probably want to run the second string ahead of the first one, as the first string is a substring and would not allow the other one to run at all
There was a problem hiding this comment.
@mauromsl This is what I think is happening - where have I gone wrong?
forward migration:
('olh', '#content aside', '#content .side-info'),
('olh', '#content .side-info h3', '#content .side-info h2'),first content aside becomes content .side-info, this means that content aside h3 is now content .side-info h3
Then content .side-info h3 becomes content .side-info h2.
for the reverse:
('olh', '#content aside', '#content .side-info'),
('olh', '#content aside h3', '#content aside h2'),first content .side-info becomes content aside, which means content .side-info h2 is now content aside h2
then content aside h2 becomes content aside h3
StephDriver
force-pushed
the
a11y-structure-css-updates
branch
from
592953b to
ec10021
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this migrates custom styling to match the changes in openlibhums/janeway#4232