-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add continue feature for depletion #3272
Open
lewisgross1296
wants to merge
2
commits into
openmc-dev:develop
Choose a base branch
from
lewisgross1296:auto_continue_depletion
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
"""Unit tests for openmc.deplete continue run capability. | ||
|
||
These tests run in two steps: first a normal run and then a continue run based on the prev_results | ||
""" | ||
|
||
import pytest | ||
|
||
import openmc.deplete | ||
|
||
from tests import dummy_operator | ||
|
||
# test that the continue timesteps works when the second integrate call contains all previous timesteps | ||
@pytest.mark.parametrize("scheme", dummy_operator.SCHEMES) | ||
def test_continue(run_in_tmpdir, scheme): | ||
# set up the problem | ||
|
||
bundle = dummy_operator.SCHEMES[scheme] | ||
|
||
operator = dummy_operator.DummyOperator() | ||
|
||
# take first step | ||
bundle.solver(operator, [0.75], 1.0).integrate() | ||
|
||
# restart | ||
prev_res = openmc.deplete.Results( | ||
operator.output_dir / "depletion_results.h5") | ||
operator = dummy_operator.DummyOperator(prev_res) | ||
|
||
# if continue run happens, test passes | ||
bundle.solver(operator, [0.75, 0.75], [1.0, 1.0], continue_timesteps = True).integrate() | ||
|
||
@pytest.mark.parametrize("scheme", dummy_operator.SCHEMES) | ||
def test_mismatched_initial_steps(run_in_tmpdir, scheme): | ||
"""Test to ensure that a continue run with different initial steps is properly caught""" | ||
|
||
# set up the problem | ||
|
||
bundle = dummy_operator.SCHEMES[scheme] | ||
|
||
operator = dummy_operator.DummyOperator() | ||
|
||
# take first step | ||
bundle.solver(operator, [0.75, 0.75], [1.0,1.0]).integrate() | ||
|
||
# restart | ||
prev_res = openmc.deplete.Results( | ||
operator.output_dir / "depletion_results.h5") | ||
operator = dummy_operator.DummyOperator(prev_res) | ||
|
||
# continue run with different previous step should cause a ValueError | ||
# note the first step matches but the second does not while the third is a new step | ||
with pytest.raises(ValueError): | ||
bundle.solver(operator, [0.75, 0.5, 0.75], [1.0, 2.0, 1.0], continue_timesteps = True).integrate() |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm realizing now that I don't think
openmc.deplete.Results
has aget_source_rates()
function. It seems like individual operators have asource_rates
member, but I'm wondering if a method inopenmc.deplete.Results
parallel toget_times()
would be useful for others. I noticedopenmc.deplete.abc.Integrator
has an__iter__()
method but it doesn't return all the source rates, just the source rate and time (for a given iteration?)It seems like maybe the appropriate line should be
though I'm wondering if the length of
get_times()
andoperator.source_rates
might have different lengths.Tests were passing because I never added a test that hits this code, I will push up a test very soon (and likely it will fail)