Skip to content

Conversation

@paulromano
Copy link
Contributor

Description

I tried using the little-known settings.no_reduce option recently (instructs each MPI rank to treat its own tally contributions as a single realization rather than reducing tallies across all MPI ranks) and found that it was broken due to a normalization error. This PR fixes the bug and adds a test so that it doesn't break in the future.

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format (version 15) on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

Copy link
Contributor

@pshriwise pshriwise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but I'll let it sit for a couple of days so others can have a look as well.

@paulromano paulromano merged commit bd76fc0 into openmc-dev:develop Nov 3, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants