Quadric surface small fixes #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pshriwise
reviewed
Nov 22, 2024
| @@ -58,7 +58,7 @@ def characterize_general_quadratic( surface ): #s surface | |||
|
|
|||
| Aai = np.linalg.pinv( Aa ) | |||
|
|
|||
| C = Aai * B | |||
| C = np.dot(Aai, B) | |||
There was a problem hiding this comment.
Good good catch. Thank you
pshriwise
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
A small update providing names for the eigenvalues and eigenvectors as they come out of the numpy call for clarity and I think this looks good. Thank you for the corrections @fnovais11.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a few problems when I was dealing with quadric surface types. The radius was off, and I tracked down some of the problems that were fixed by a small correction to the
gqs.pythat were affecting the calculation of radius in therotation_to_axis_anglefunction.