Use faster algorithm for generating contours #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pshriwise
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
Interesting! Thanks for looking into that @paulromano. I tried this and noticed a similar speedup with the change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Axes.contourmethod from matplotlib uses ContourPy under the hood, and there are several algorithms that are available. I noticed that the default one that matplotlib uses ("mpl2014") is a bit older than the default one for ContourPy ("serial"). This PR explicitly uses the "serial" algorithm whenever we callax.contour, which in my testing results in a 2x speedup for generating contours.The problem where I noticed this is as shown below. I was looking at a mesh annotation for a 80x80x80 mesh, and generating the mesh annotation took 25 seconds. Switching to the "serial" algorithm cut that down to 13 seconds.
