Fix: add double token in authorization header #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reintroduces two possible auth tokens that have been removed in #6 . To follow the strategy of only adding auth tokens in the Authorization header, this assumes two auth token to be comma separated.
It is possible to have only one token (for requests against the crate) or two tokens (for requests against an mcp - that also requires a request against the mcp). More are not accepted.
This seems to violate the RFC defining http headers and the auth header to only be a single value but since this is not a public api it is acceptable with the added advantage of using the standard authorization header over a custom header.