Skip to content

MCP Status - Tooltip and Table width change #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 23, 2025

Conversation

Hubert-Szczepanski-SAP
Copy link
Contributor

@Hubert-Szczepanski-SAP Hubert-Szczepanski-SAP commented Jun 20, 2025

What this PR does / why we need it:

  • Changing width of columns for MCP to be more readable
image - Adding tooltip that works over whole cell, not only hovering text.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

@n3rdc4ptn n3rdc4ptn requested a review from Copilot June 20, 2025 09:33
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the MCP status table by making cell tooltips span the full cell and adjusting column and container widths for readability.

  • Introduces a TooltipCell wrapper to show tooltips over entire cells.
  • Updates column definitions with explicit width values and wraps each cell in TooltipCell.
  • Adjusts the table container width and the translation of the transition header.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File Description
src/components/Shared/TooltipCell.tsx Added a new TooltipCell component for full-cell tooltips.
src/components/ControlPlane/MCPHealthPopoverButton.tsx Wrapped table cells in TooltipCell, set explicit column widths, changed container width, and updated scaleWidthMode.
public/locales/en.json Changed "transitionHeader" text from "Last transition time" to "Last change".

@n3rdc4ptn n3rdc4ptn requested review from n3rdc4ptn and removed request for n3rdc4ptn June 20, 2025 09:39
n3rdc4ptn
n3rdc4ptn previously approved these changes Jun 20, 2025
Copy link
Member

@n3rdc4ptn n3rdc4ptn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hubert-Szczepanski-SAP lgtm, I also requested the CoPilot Review. Please have a look.

@n3rdc4ptn n3rdc4ptn merged commit 70b7d34 into main Jun 23, 2025
5 checks passed
@n3rdc4ptn n3rdc4ptn deleted the bugfix/changing-mcp-status-table-width branch June 23, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants