Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make compatible with Django 4.2 (fixes DEV-51) #520

Merged
merged 1 commit into from
Nov 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion enhydris/admin/__init__.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from django.conf import settings
from django.contrib import admin
from django.utils.translation import ugettext_lazy as _
from django.utils.translation import gettext_lazy as _

from parler.admin import TranslatableAdmin

Expand Down
2 changes: 1 addition & 1 deletion enhydris/admin/garea.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
from django.http import HttpResponseRedirect
from django.template.response import TemplateResponse
from django.urls import path
from django.utils.translation import ugettext_lazy as _
from django.utils.translation import gettext_lazy as _

from enhydris import models

Expand Down
2 changes: 1 addition & 1 deletion enhydris/admin/station.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
from django.contrib import admin, messages
from django.contrib.sites.models import Site
from django.db.models import Q, TextField
from django.utils.translation import ugettext_lazy as _
from django.utils.translation import gettext_lazy as _

import nested_admin
import pandas as pd
Expand Down
2 changes: 1 addition & 1 deletion enhydris/forms/auth.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from django.utils.translation import ugettext_lazy as _
from django.utils.translation import gettext_lazy as _

from captcha.fields import CaptchaField
from registration.forms import RegistrationFormTermsOfService
Expand Down
2 changes: 1 addition & 1 deletion enhydris/forms/timeseries.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
from django import forms
from django.utils.translation import ugettext_lazy as _
from django.utils.translation import gettext_lazy as _

from enhydris import models

Expand Down
10 changes: 8 additions & 2 deletions enhydris/models/timeseries.py
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,10 @@ def get_start_date():
return self.timeseriesrecord_set.earliest().timestamp.astimezone(
ZoneInfo(self.timeseries_group.gentity.display_timezone)
)
except TimeseriesRecord.DoesNotExist:
except (TimeseriesRecord.DoesNotExist, ValueError):
# The ValueError above is for the case where the Timeseries object does
# not have a primary key yet (has not been saved), which causes a
# problem in Django>=4.
return None

return cache.get_or_set(f"timeseries_start_date_{self.id}", get_start_date)
Expand All @@ -158,7 +161,10 @@ def get_end_date():
return self.timeseriesrecord_set.latest().timestamp.astimezone(
ZoneInfo(self.timeseries_group.gentity.display_timezone)
)
except TimeseriesRecord.DoesNotExist:
except (TimeseriesRecord.DoesNotExist, ValueError):
# The ValueError above is for the case where the Timeseries object does
# not have a primary key yet (has not been saved), which causes a
# problem in Django>=4.
return None

return cache.get_or_set(f"timeseries_end_date_{self.id}", get_end_date)
Expand Down
2 changes: 1 addition & 1 deletion enhydris/tasks.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
from django.conf import settings
from django.contrib.auth.models import User
from django.core.mail import send_mail
from django.utils.translation import ugettext_lazy as _
from django.utils.translation import gettext_lazy as _

import celery

Expand Down
2 changes: 1 addition & 1 deletion enhydris/telemetry/forms.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
from django import forms
from django.utils.translation import ugettext_lazy as _
from django.utils.translation import gettext_lazy as _

from enhydris.telemetry import TelemetryError
from enhydris.telemetry.models import Telemetry, timezone_choices
Expand Down
2 changes: 1 addition & 1 deletion enhydris/telemetry/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

from django.core.validators import MaxValueValidator, MinValueValidator
from django.db import IntegrityError, models
from django.utils.translation import ugettext_lazy as _
from django.utils.translation import gettext_lazy as _

import iso8601

Expand Down
2 changes: 1 addition & 1 deletion enhydris/telemetry/types/__init__.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from django.utils.translation import ugettext_lazy as _
from django.utils.translation import gettext_lazy as _


class TelemetryAPIClientBase:
Expand Down
2 changes: 1 addition & 1 deletion enhydris/telemetry/types/addupi.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import datetime as dt
from io import StringIO

from django.utils.translation import ugettext_lazy as _
from django.utils.translation import gettext_lazy as _

import requests
from defusedxml import ElementTree
Expand Down
2 changes: 1 addition & 1 deletion enhydris/telemetry/types/meteoview2.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
from io import StringIO
from zoneinfo import ZoneInfo

from django.utils.translation import ugettext_lazy as _
from django.utils.translation import gettext_lazy as _

import requests

Expand Down
2 changes: 1 addition & 1 deletion enhydris/telemetry/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
from django.http import Http404, HttpResponseRedirect
from django.shortcuts import render
from django.urls import reverse
from django.utils.translation import ugettext_lazy as _
from django.utils.translation import gettext_lazy as _
from django.views.generic.base import View
from django.views.generic.detail import DetailView
from django.views.generic.list import ListView
Expand Down
2 changes: 1 addition & 1 deletion requirements-dev.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
model-mommy>=1.6.0
django-cors-headers<4
django-cors-headers>=4,<5
sphinx>=4
django-selenium-clean>=1,<2
beautifulsoup4>=4.4
Expand Down
4 changes: 2 additions & 2 deletions requirements.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Django>=3.2,<4
Django>=4.2,<5
djangorestframework>=3.9,<4
gdal>=1.6
iso8601
Expand All @@ -11,7 +11,7 @@ django-rest-captcha>=0.1.0,<1
django-parler>=2.2,<3
django-parler-rest>=2,<3
django-geowidgets>=0.1.1,<1
django-nested-admin>=3.2,<4
django-nested-admin>=4.1,<5
django-crequest
celery>=5.2.2,<6
django-registration-redux>=2.9,<3
Expand Down
Loading