Re-apply referencing IEEE schemas #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The previous attempt at updating Open mHealth schemas to use IEEE standard schemas resulted in failed validations in the CI workflow on GitHub Actions.
Solution
The failure only manifests when using newer versions of the jsonschema library. CI was pulling the latest libraries, but running the validator locally used an older cached version. So validation passed locally but failed on CI.
While the issue surfaces in newer versions of the jsonschema library, it's unclear what causes it. To unblock things, a
requirements.txtfile has been introduced that specifies an older working version of the jsonschema dependency and the CI pipeline has been updated to use it. Instructions have also been updated in README.md.Miscellaneous
The GitHub Actions CI workflow was allowing PRs to be merged to
maineven if validation failed. A protected branch check has been added, a PR can no longer be merged if validation is failing.