Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Fixes for v0.15.1 #1358

Merged
merged 9 commits into from
Oct 14, 2024
Merged

Test Fixes for v0.15.1 #1358

merged 9 commits into from
Oct 14, 2024

Conversation

LennartPurucker
Copy link
Contributor

Minor fixes to tests to make them work (again).

@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.37%. Comparing base (3155b5f) to head (83c78eb).
Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
openml/config.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1358      +/-   ##
===========================================
+ Coverage    81.71%   84.37%   +2.66%     
===========================================
  Files           38       38              
  Lines         5261     5262       +1     
===========================================
+ Hits          4299     4440     +141     
+ Misses         962      822     -140     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@eddiebergman eddiebergman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You waste my time reviewing this near perfect code, how dare you? There's a merge button you can just press you know, I will find you, I will visit you, and... I will waste your time...

Oh but also can you fix the logging of can't create the config_dir as discussed xx

@eddiebergman eddiebergman self-requested a review October 14, 2024 16:44
Copy link
Collaborator

@eddiebergman eddiebergman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You didn't even request a review from me after making the changes, it's like you're trying to waste not only my time, but your time and everyone elses time who now has to read this laboriously but lovingly crafted collection of letters assembled into a structure known as a paragraph.

I hope you're happy... but yeah LGTM

@eddiebergman eddiebergman merged commit d3bb775 into develop Oct 14, 2024
11 of 14 checks passed
@eddiebergman eddiebergman deleted the fix/tests branch October 14, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants