Generator generates webpack.config.js that adds version number to bun… #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dled OWA - Generates new webpack.config file that can add version number to bundled OWA - Version number can be toggled with boolean - This PR is dependent on another PR in `openmrs-module-owa` by the same name, `CB-164`, which removes version number from OWA URL.
|
Can anyone comment on why this might be happening? Is there something else we need to do? Thanks. |
|
Have you looked at the travis error log details? |
|
Yes I took a look, it errors when `npm test` is run, however the error
seems to be on a file we did not modify, also when `npm test` is run
locally, all tests pass on my machine. Do you have an clue as to why they
fail with Travis?
On Apr 16, 2019 4:00 PM, "dkayiwa" <[email protected]> wrote:
Have you looked at the travis error log details?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AXQrs8SJ-r2V9DcDqnYk3pR71tB63WR6ks5vhjn8gaJpZM4cqBuN>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CB-164 Adding version number to bundled OWA file name
Description of what I changed
yeoman generator now generates a webpack.config.js file that appends the version number to an OWA when bundled. Can be turned on and off with boolean
packageIncludesVersionNumber.Another PR in
openmrs-module-owaby the same name (CB-164) removes the version number from the OWA URL.Issue I worked on
see https://issues.openmrs.org/browse/CB-164
Checklist:
My pull request only contains ONE single commit
(the number above, next to the 'Commits' tab is 1).
My IDE is configured to follow the code style of this project.
I have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
I ran
mvn clean packageright before creating this pull request andadded all formatting changes to my commit.
All new and existing tests passed.
My pull request is based on the latest changes of the master branch.