Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ramki] Upgrade vulnerable node packages #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rmkanda
Copy link

@rmkanda rmkanda commented Aug 30, 2019

Upgrade node packages with vulnerabilities

Description of what I changed

Updated few node packages with vulnerabilities

Checklist:

  • My pull request only contains ONE single commit
    (the number above, next to the 'Commits' tab is 1).
  • My IDE is configured to follow the code style of this project.
  • No new tests are required and existing tests are passing.
  • All new and existing tests passed.
  • My pull request is based on the latest changes of the master branch.

@dkayiwa
Copy link
Member

dkayiwa commented Aug 30, 2019

Did you see the travis build failure?

@HerbertYiga
Copy link

@rmkanda you can also add a ticket link as recommended here https://wiki.openmrs.org/display/docs/Pull+Request+Tips

@rmkanda
Copy link
Author

rmkanda commented Aug 30, 2019

@dkayiwa @HerbertYiga All the tests are passing in my local machine.
I saw the build failure when I created the pull request. I checked the travis log... no clues...
I also saw that the previous builds are also not passed... Looks like an existing issue.

image

@psbrandt Please help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants