Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing OpenMRS releases repo #21

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixing OpenMRS releases repo #21

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
961d385
Fixing Distribution Management OpenMRS relases repo
Ruhanga Apr 27, 2023
ca25db7
Adding SNAPSHOT repository to config-test-parent pom
Ruhanga Apr 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions integration-tests/src/test/resources/config-test-parent/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<plugin>
<groupId>org.openmrs.maven.plugins</groupId>
<artifactId>openmrs-packager-maven-plugin</artifactId>
<version>1.7.0-SNAPSHOT</version>
<version>1.7.0</version>
<executions>
<execution>
<id>generate-resource-filters</id>
Expand Down Expand Up @@ -44,12 +44,9 @@

<pluginRepositories>
<pluginRepository>
<id>openmrs-repo</id>
<name>OpenMRS Nexus Repository</name>
<url>https://mavenrepo.openmrs.org/nexus/content/repositories/public</url>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think changing from /public to /releases here is unnecessary....

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately I can't explain this Bamboo build failure. I had expected it to pass without this change.

Copy link
Member

@ibacher ibacher Apr 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this change going to fix it? If the problem is that (for w/e reason) it's looking for the SNAPSHOT version, that's also not in the /releases repo (We have a /snapshots repo for those... It would be fine to add the snapshots repo as another plugin repository...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, I see. I had over looked the fact that https://mavenrepo.openmrs.org/nexus/content/repositories/public is not a SNAPSHOT repository.

<snapshots>
<enabled>false</enabled>
</snapshots>
<id>openmrs-repo-releases</id>
<name>OpenMRS Releases Repo</name>
<url>https://openmrs.jfrog.io/artifactory/releases</url>
</pluginRepository>
</pluginRepositories>

Expand Down
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@
<repository>
<id>openmrs-repo-releases</id>
<name>OpenMRS Releases Repo</name>
<url>https://mavenrepo.openmrs.org/nexus/content/repositories/releases</url>
<url>https://openmrs.jfrog.io/artifactory/releases</url>
</repository>
<snapshotRepository>
<id>openmrs-repo-snapshots</id>
Expand Down