SDK-373 - Add goal to packager plugin to facilitate transition from c… #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onfig to content packages
mogoodrich
reviewed
Dec 17, 2024
|
|
||
| /** | ||
| * The purpose of this Mojo is to support the migration away from config packages to content packages | ||
| * The intent is to bundle up the same configurations as content packages |
There was a problem hiding this comment.
Config packages never lived outside of PIH, did they, or am I forgetting? Might be worth referencing these as "PIH" config packages in the comments to help people 10 years from now remember what they were (or just realize they can ignore them)
There was a problem hiding this comment.
Oh, right, the packager plugin... maybe just reference that in the comments?
There was a problem hiding this comment.
Duh, sorry for all the spam... I was thinking this change was in the SDK... of course you don't need to reference the packager plugin since this is the package plugin... anyway, LGTM, ignore my comments...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…onfig to content packages