Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRUNK-6271: Log4JCompatibilityTest fail on github workflow #4779

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ManojLL
Copy link
Contributor

@ManojLL ManojLL commented Oct 10, 2024

Description of what I changed

added logging levels to logger

Issue I worked on

see https://issues.openmrs.org/browse/TRUNK-6271

Checklist: I completed these to help reviewers :)

  • My IDE is configured to follow the code style of this project.

    No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)

    No? -> write tests and add them to this commit git add . && git commit --amend

  • I ran mvn clean package right before creating this pull request and
    added all formatting changes to my commit.

    No? -> execute above command

  • All new and existing tests passed.

    No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

  • My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

Copy link
Member

@wikumChamith wikumChamith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dkayiwa, @ibacher can you take a look at this?

@ibacher
Copy link
Member

ibacher commented Oct 11, 2024

This fundamentally subverts what this test is actually testing s this isn't really a great solution to the problem...

@ManojLL
Copy link
Contributor Author

ManojLL commented Oct 12, 2024

@ibacher what about adding logger for "Log4JCompatibility" in log4j2.xml file. By adding the "Log4JCompatibility" logger configuration, 'log4j' can capture all log messages for this logger and send them to the console. This allows our test to capture and check the log messages produced during the test.

<Logger name="Log4JCompatibility" level="ALL" additivity="false"> <AppenderRef ref="CONSOLE" /> </Logger>

@wikumChamith
Copy link
Member

@dkayiwa, @ibacher, is this the right time to remove support for Log4j 1.x?

/**
* Class to ensure that we maintain some level of compatibility with Log4J 1.X
* At some point in the future, this compatibility guarantee should be removed.
*/

@ibacher
Copy link
Member

ibacher commented Oct 18, 2024

@wikumChamith No. We haven't actually removed the Log4J 1.x API from any modules that use it.

@ManojLL The Log4JCompatibility logger is just something that exists for the purposes of this test. Adding it to the file makes it more permanent than it needs to be.

@ManojLL
Copy link
Contributor Author

ManojLL commented Oct 19, 2024

@ibacher initializing the log4j logger after the log4j2 memory adapter starts, that cause to set the compatinilityLogger level to OFF.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants