Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable showing upcoming appointments on the visit note #810

Merged
merged 1 commit into from
May 9, 2024

Conversation

mogoodrich
Copy link
Member

No description provided.

@@ -32,5 +32,8 @@
},
"visitQueueNumberAttributeUuid": "",
"defaultFacilityUrl": ""
},
"@openmrs/esm-styleguide": {
"Brand color #1": "#005d5d"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OCD, I alphabetized

"@openmrs/esm-styleguide": {
"Brand color #1": "#005d5d"
"@openmrs/esm-patient-chart-app": {
"showUpcomingAppointments": true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enabling this configures the visit note so that it will show upcoming appointments when entering a visit note. Seemed like it would make sense to turn this on in the refapp for demo purposes? And this seems like the proper place to configure the refapp?

Copy link
Contributor

@chibongho chibongho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mseaton mseaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK by me, but defer to those who know more about this feature and what we want in the refapp

@mogoodrich
Copy link
Member Author

Coincidentally, Usama just asked me if an appointments bug I filed is reproducible on dev3... and it isn't without this change, so I'm going to merge this in, but @gracepotma @ibacher feel free to weigh in with objections. Alternatively, we could just make the default value for this property "true", but that would be a behavior change.

@mogoodrich mogoodrich merged commit 2c1b213 into main May 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants