-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable showing upcoming appointments on the visit note #810
Conversation
@@ -32,5 +32,8 @@ | |||
}, | |||
"visitQueueNumberAttributeUuid": "", | |||
"defaultFacilityUrl": "" | |||
}, | |||
"@openmrs/esm-styleguide": { | |||
"Brand color #1": "#005d5d" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OCD, I alphabetized
"@openmrs/esm-styleguide": { | ||
"Brand color #1": "#005d5d" | ||
"@openmrs/esm-patient-chart-app": { | ||
"showUpcomingAppointments": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
enabling this configures the visit note so that it will show upcoming appointments when entering a visit note. Seemed like it would make sense to turn this on in the refapp for demo purposes? And this seems like the proper place to configure the refapp?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK by me, but defer to those who know more about this feature and what we want in the refapp
Coincidentally, Usama just asked me if an appointments bug I filed is reproducible on dev3... and it isn't without this change, so I'm going to merge this in, but @gracepotma @ibacher feel free to weigh in with objections. Alternatively, we could just make the default value for this property "true", but that would be a behavior change. |
No description provided.