-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix) Fix mapping errors when adding SOAP note concepts #831
Conversation
@CynthiaKamau when i apply the changes in this pull request, this is what i get in the logs: https://pastebin.com/dLvmccCU |
This pr will sort that out |
I am already using version 2.3.0 of the openconceptlab module: https://github.com/openmrs/openmrs-distro-referenceapplication/blob/main/distro/pom.xml#L36 |
9cd8cca
to
f9daa0e
Compare
f9daa0e
to
4c44233
Compare
@dkayiwa i have fixed the mapping errors from the soap note |
@CynthiaKamau this is what i get after running these changes on a fresh installation: https://pastebin.com/YzJ2UphK |
Those seem to originate from |
4c44233
to
eb95379
Compare
@CynthiaKamau - There were some failing tests regarding patientmanagement but after a re-run, they passed and all is green now. @dkayiwa what do you think? |
@alaboso what do you say about this? |
There were some drug concepts in the |
I have tested and confirmed that all is now well. Thanks @CynthiaKamau and @alaboso 👍 |
This pr is dependent on this pr in the initializer