Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Fix mapping errors when adding SOAP note concepts #831

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Conversation

CynthiaKamau
Copy link
Contributor

This pr is dependent on this pr in the initializer

@CynthiaKamau CynthiaKamau requested a review from dkayiwa July 23, 2024 12:28
@dkayiwa
Copy link
Member

dkayiwa commented Jul 24, 2024

@CynthiaKamau when i apply the changes in this pull request, this is what i get in the logs: https://pastebin.com/dLvmccCU

@CynthiaKamau
Copy link
Contributor Author

@CynthiaKamau when i apply the changes in this pull request, this is what i get in the logs: https://pastebin.com/dLvmccCU

This pr will sort that out

@dkayiwa
Copy link
Member

dkayiwa commented Jul 25, 2024

This pr will sort that out

I am already using version 2.3.0 of the openconceptlab module: https://github.com/openmrs/openmrs-distro-referenceapplication/blob/main/distro/pom.xml#L36

@CynthiaKamau CynthiaKamau force-pushed the soap-note-b branch 2 times, most recently from 9cd8cca to f9daa0e Compare August 5, 2024 14:16
@CynthiaKamau
Copy link
Contributor Author

This pr will sort that out

I am already using version 2.3.0 of the openconceptlab module: https://github.com/openmrs/openmrs-distro-referenceapplication/blob/main/distro/pom.xml#L36

This pr will sort that out

I am already using version 2.3.0 of the openconceptlab module: https://github.com/openmrs/openmrs-distro-referenceapplication/blob/main/distro/pom.xml#L36

@dkayiwa i have fixed the mapping errors from the soap note

@dkayiwa
Copy link
Member

dkayiwa commented Aug 7, 2024

@CynthiaKamau this is what i get after running these changes on a fresh installation: https://pastebin.com/YzJ2UphK

@CynthiaKamau
Copy link
Contributor Author

https://pastebin.com/YzJ2UphK

Those seem to originate from drugs_concepts-core_demo.csv if im not wrong

@alaboso
Copy link
Contributor

alaboso commented Aug 13, 2024

@CynthiaKamau - There were some failing tests regarding patientmanagement but after a re-run, they passed and all is green now. @dkayiwa what do you think?

@dkayiwa
Copy link
Member

dkayiwa commented Aug 15, 2024

Those seem to originate from drugs_concepts-core_demo.csv if im not wrong

@alaboso what do you say about this?

@alaboso
Copy link
Contributor

alaboso commented Aug 16, 2024

Those seem to originate from drugs_concepts-core_demo.csv if im not wrong

@alaboso what do you say about this?

There were some drug concepts in the openmrs_SOAP_vSOAP_Note_autoexpand-SOAP_Note.****.zip that were also in the default drugs_concepts-core_demo.csv - We have since removed them from the OCL zip file in favor of those in the default distro csv. @dkayiwa @CynthiaKamau

@dkayiwa
Copy link
Member

dkayiwa commented Aug 16, 2024

I have tested and confirmed that all is now well. Thanks @CynthiaKamau and @alaboso 👍

@dkayiwa dkayiwa merged commit 9ecc03e into main Aug 16, 2024
13 checks passed
NethmiRodrigo pushed a commit to openmrs/path-drc-emr that referenced this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants