Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) Add mental health assessment form #843

Merged
merged 2 commits into from
Oct 10, 2024
Merged

(feat) Add mental health assessment form #843

merged 2 commits into from
Oct 10, 2024

Conversation

NethmiRodrigo
Copy link
Contributor

This PR adds the PHQ-9 Screening Tool form.

https://openmrs.atlassian.net/browse/O3-3717

@denniskigen denniskigen changed the title (chore): Add mental assesment form (feat) Add mental assesment form Oct 8, 2024
@denniskigen denniskigen changed the title (feat) Add mental assesment form (feat) Add mental health assessment form Oct 8, 2024
Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, Nethmi.

@denniskigen
Copy link
Member

@ibacher does the Build and Validate Configuration check have to pass for this to be merged in?

@ibacher
Copy link
Member

ibacher commented Oct 9, 2024

@denniskigen They definitely should pass or else there's very likely something broken.

@ibacher
Copy link
Member

ibacher commented Oct 9, 2024

In this case, the failure message is: "Form Encounter type Mental Health Assessment could not be found. Please ensure that this encountertype is either loaded by Iniz or loaded in the system before Iniz runs." So that's a pretty obvious "we're missing necessary metadata to make this form usable" issue.

@denniskigen
Copy link
Member

Aha!

CleanShot 2024-10-09 at 4  12 44@2x

@denniskigen
Copy link
Member

@ibacher that should be included in this diff, right? Could you take care of that, @NethmiRodrigo?

@ibacher
Copy link
Member

ibacher commented Oct 9, 2024

Yeah, if we're requiring an EncounterType it should be in the metadata.

@NethmiRodrigo
Copy link
Contributor Author

NethmiRodrigo commented Oct 10, 2024

Any idea why this might be happening @ibacher @denniskigen causing the form builder e2e to fail?
Screenshot 2024-10-10 at 11 43 08 AM

@denniskigen
Copy link
Member

I've just rerun the tests, @NethmiRodrigo. Should be ok now.

@denniskigen denniskigen merged commit 64b03be into main Oct 10, 2024
13 checks passed
@denniskigen denniskigen deleted the chore/O3-3717 branch October 10, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants