Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reporting app to distro and update reporting and reportingrest modules #891

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

druchniewicz
Copy link
Contributor

@druchniewicz druchniewicz commented Feb 6, 2025

This diff does two things:

  • Adds the new reporting ESM to the spa-assemble-config.json file so it gets included in the distro.
  • Updates the reporting and reportingrest backend modules to newer versions to fix an outdated backend module dependencies warning shown when running the reporting app.

@druchniewicz
Copy link
Contributor Author

@mseaton @denniskigen as reporting and reportingrest modules have been released and esm-reports-app is available in openmrs npm registry I've updated versions in ref app according to Denis's suggestion

@druchniewicz
Copy link
Contributor Author

@denniskigen @mseaton

1 similar comment
@druchniewicz
Copy link
Contributor Author

@denniskigen @mseaton

@mseaton
Copy link
Member

mseaton commented Feb 10, 2025

@denniskigen @mseaton

I'm fine / agree with bumping up the backend module versions, but defer to @ibacher / @denniskigen / @gracepotma on the inclusion of the new esm.

@denniskigen denniskigen requested a review from ibacher February 10, 2025 19:34
Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we want to include it, @mseaton. Thanks for the review!

@denniskigen denniskigen changed the title Update reporting modules versions Add reporting app to distro and update reporting and reportingrest modules Feb 12, 2025
@druchniewicz druchniewicz force-pushed the add-reports-dependencies branch from 93ac3f2 to a3f2939 Compare February 12, 2025 12:59
@denniskigen denniskigen merged commit 8b3e620 into openmrs:main Feb 12, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants