-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
O3-1494: Added Report Admin pages #45
base: main
Are you sure you want to change the base?
Conversation
- Reports overview - Report schedules overview
I expect that Palladium-Kenya will be interested in using this so I reached out to @ojwanganto: @jecihjoy he recommended you review this PR :) |
Changed to DRAFT, because it's not adapted to changes in API in openmrs/openmrs-module-reportingrest#33 |
So TBH I didn't notice until now that this PR is almost 12k lines of code - woah. Reviewing this make take our support & community members quite some time. In future smaller PRs earlier would be more advisable :) Hope that makes sense! |
@gracepotma - Should we have this work as part of the admin tools or a separate reporting-esm? |
@ojwanganto Well, it is a separate esm, just in this mono-repo. I don't think we need individual GitHub repos for everything. |
Makes sense @ibacher. I think i didn't get into the source code. I just looked at the project URL. Sorry about that |
@pwargulak when do you think we can start testing this work? It already provides a good foundation for the reporting functionality we need |
@ojwanganto We are working on bringing the BE code to sufficient quality, the PRs related to BE are listed here once they are merged we'll adapt the FE (this PR) and then it can be tested. |
Thanks for the update @pwargulak. |
Iam curios to know if anyone has used this.. may need it somewhere @pwargulak @jecihjoy |
Summary
The PR contains implementation of Report administration pages, including:
Pages are accessible via System Administration menu.
It implements designs documented here (newest mocks section).
Screenshots
Issue
https://openmrs.atlassian.net/browse/O3-1494