Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

O3-1494: Added Report Admin pages #45

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pwargulak
Copy link

Summary

The PR contains implementation of Report administration pages, including:

  1. Reports overview page which shows history of Report executions, inc current and planned execution.
  2. Reports schedule where user can schedule reports to be execute once at some time later, daily, weekly at specific day(-s), monthly at the end or start of a month (this is a copy o OMRS 1.x functionality).

Pages are accessible via System Administration menu.
It implements designs documented here (newest mocks section).

Screenshots

screencapture-localhost-8081-openmrs-spa-reports-2024-02-16-15_34_13
screencapture-localhost-8081-openmrs-spa-reports-2024-02-16-15_34_20
screencapture-localhost-8081-openmrs-spa-reports-scheduled-overview-2024-02-16-15_34_34
screencapture-localhost-8081-openmrs-spa-reports-scheduled-overview-2024-02-16-15_35_14

Issue

https://openmrs.atlassian.net/browse/O3-1494

- Reports overview
- Report schedules overview
@gracepotma
Copy link

I expect that Palladium-Kenya will be interested in using this so I reached out to @ojwanganto: @jecihjoy he recommended you review this PR :)

@pwargulak pwargulak marked this pull request as draft February 27, 2024 15:02
@pwargulak
Copy link
Author

Changed to DRAFT, because it's not adapted to changes in API in openmrs/openmrs-module-reportingrest#33

@gracepotma gracepotma requested review from ibacher and removed request for ibacher February 27, 2024 18:39
@gracepotma
Copy link

So TBH I didn't notice until now that this PR is almost 12k lines of code - woah. Reviewing this make take our support & community members quite some time. In future smaller PRs earlier would be more advisable :) Hope that makes sense!

@ojwanganto
Copy link

@gracepotma - Should we have this work as part of the admin tools or a separate reporting-esm?

@ibacher
Copy link
Member

ibacher commented Mar 28, 2024

@ojwanganto Well, it is a separate esm, just in this mono-repo. I don't think we need individual GitHub repos for everything.

@ojwanganto
Copy link

Makes sense @ibacher. I think i didn't get into the source code. I just looked at the project URL. Sorry about that

@ojwanganto
Copy link

@pwargulak when do you think we can start testing this work? It already provides a good foundation for the reporting functionality we need

@pwargulak
Copy link
Author

@ojwanganto We are working on bringing the BE code to sufficient quality, the PRs related to BE are listed here once they are merged we'll adapt the FE (this PR) and then it can be tested.

@ojwanganto
Copy link

Thanks for the update @pwargulak.

@tendomart
Copy link

Iam curios to know if anyone has used this.. may need it somewhere @pwargulak @jecihjoy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants