code review

openmrs · Oct 2, 2024 · 5073fa3 · 5073fa3
1 parent 71ce774
commit 5073fa3
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/src/components/interactive-builder/interactive-builder.component.tsx b/src/components/interactive-builder/interactive-builder.component.tsx
@@ -5,6 +5,7 @@ import { v4 as uuidv4 } from 'uuid';
 import { Button, Accordion, AccordionItem, Tile } from '@carbon/react';
 import { type DynamicExtensionSlot, type Schema } from '../../types';
 import styles from './interactive-builder.scss';
+import { getSubMenuSlotDetails } from '../../helpers';
 
 interface InteractiveBuilderProps {
   schema: Schema;
@@ -133,13 +134,6 @@ const InteractiveBuilder = ({ schema, onSchemaChange }: InteractiveBuilderProps)
             submenuConfig.add.map((submenuKey) => {
               const submenuDetails = submenuConfig.configure[submenuKey];
               const subMenuSlot = submenuDetails?.slot;
-              const getSubMenuSlotDetails = (schema, subMenuSlot) => {
-                const patientChartApp = schema['@openmrs/esm-patient-chart-app'];
-                if (patientChartApp && patientChartApp.extensionSlots) {
-                  return patientChartApp.extensionSlots[subMenuSlot];
-                }
-                return null;
-              };
               const subMenuSlotDetails = getSubMenuSlotDetails(schema, subMenuSlot);
               return (
                 <Accordion key={submenuKey}>

diff --git a/src/helpers.ts b/src/helpers.ts
@@ -5,3 +5,11 @@ export const generateNodeId = (string) =>
       return index === 0 ? word.toLowerCase() : word.toUpperCase();
     })
     .replace(/\s+/g, '');
+
+export const getSubMenuSlotDetails = (schema, subMenuSlot) => {
+  const patientChartApp = schema['@openmrs/esm-patient-chart-app'];
+  if (patientChartApp && patientChartApp.extensionSlots) {
+    return patientChartApp.extensionSlots[subMenuSlot];
+  }
+  return null;
+};