O3-4002 Add implementation for configuring dashboard Encounter List Table component #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CynthiaKamau
force-pushed
the
O3-4002
branch
from
5157cf6 to
765c1ae
Compare
CynthiaKamau
changed the title
ODORA0
approved these changes
Oct 1, 2024
eudson
reviewed
Oct 1, 2024
| @@ -108,17 +131,63 @@ const InteractiveBuilder = ({ schema, onSchemaChange }: InteractiveBuilderProps) | |||
| {submenuConfig ? ( | |||
| submenuConfig.add.map((submenuKey) => { | |||
| const submenuDetails = submenuConfig.configure[submenuKey]; | |||
| const subMenuSlot = submenuDetails?.slot; | |||
| const getSubMenuSlotDetails = (schema, subMenuSlot) => { | |||
There was a problem hiding this comment.
@CynthiaKamau is there a reason why this needs to be encapsulated on a function? I only see this function being used once and its actual part of map so it will be local to this code, correct?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
For changes to apps
If applicable
Summary
Add implementation for configuring dashboard Encounter List Table component
Screenshots
Screen.Recording.2024-09-30.at.19.57.57.mov
Related Issue
Other