(test) 03-3853: Add Unit Tests for Datepicker Component. #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasharma05
reviewed
Sep 19, 2024
There was a problem hiding this comment.
Hi @Samstar10!
Can you please connect with Sachit and combine #1130 together.
Thanks!
CC: @NethmiRodrigo
Comment on lines
+8
to
+25
| beforeAll(() => { | ||
| window.i18next = { | ||
| language: 'en', | ||
| changeLanguage: jest.fn(), | ||
| t: jest.fn((key) => key), // Simple mock for translation function | ||
| // Other properties and methods that might be required | ||
| init: jest.fn(), | ||
| getFixedT: jest.fn(), | ||
| exists: jest.fn(), | ||
| loadNamespaces: jest.fn(), | ||
| loadLanguages: jest.fn(), | ||
| use: jest.fn(), | ||
| on: jest.fn(), | ||
| off: jest.fn(), | ||
| dir: jest.fn(), | ||
| cloneInstance: jest.fn(), | ||
| } as unknown as i18nType; // Casting the mock to the correct i18n type | ||
| }); |
There was a problem hiding this comment.
Suggested change
| beforeAll(() => { | |
| window.i18next = { | |
| language: 'en', | |
| changeLanguage: jest.fn(), | |
| t: jest.fn((key) => key), // Simple mock for translation function | |
| // Other properties and methods that might be required | |
| init: jest.fn(), | |
| getFixedT: jest.fn(), | |
| exists: jest.fn(), | |
| loadNamespaces: jest.fn(), | |
| loadLanguages: jest.fn(), | |
| use: jest.fn(), | |
| on: jest.fn(), | |
| off: jest.fn(), | |
| dir: jest.fn(), | |
| cloneInstance: jest.fn(), | |
| } as unknown as i18nType; // Casting the mock to the correct i18n type | |
| }); | |
| Object.defineProperty(window, 'i18next', { | |
| value: { | |
| language: 'en', | |
| changeLanguage: jest.fn(), | |
| t: jest.fn((key) => key), // Simple mock for translation function | |
| // Other properties and methods that might be required | |
| init: jest.fn(), | |
| getFixedT: jest.fn(), | |
| exists: jest.fn(), | |
| loadNamespaces: jest.fn(), | |
| loadLanguages: jest.fn(), | |
| use: jest.fn(), | |
| on: jest.fn(), | |
| off: jest.fn(), | |
| dir: jest.fn(), | |
| cloneInstance: jest.fn(), | |
| } | |
| }) |
There was a problem hiding this comment.
There was a problem hiding this comment.
Thanks for picking this up @Samstar10! Please see the suggestions and the build failures:
| @@ -70,6 +70,7 @@ | |||
| "@openmrs/esm-translations": "workspace:*", | |||
| "@types/geopattern": "^1.2.9", | |||
| "autoprefixer": "^9.8.8", | |||
| "cross-env": "^7.0.3", | |||
| // Test to ensure that the component renders without crashing | ||
| it('renders without crashing', () => { | ||
| render(<OpenmrsDatePicker />); | ||
| expect(screen.getByRole('group')).toBeInTheDocument(); |
There was a problem hiding this comment.
See the comment in #1130
| const { container } = render(<OpenmrsDatePicker defaultValue={new Date(2024, 7, 27)} />); | ||
| expect(container.querySelector('input')).toHaveValue('2024-08-27'); | ||
| }); | ||
|
|
There was a problem hiding this comment.
Can we also add a test case to ensure that the current date is highlighted in the calendar grid? We should test this for different locales
Comment on lines
+75
to
+79
| if (input?.hasAttribute('aria-invalid')) { | ||
| expect(input).toHaveAttribute('aria-invalid', 'false'); | ||
| } else { | ||
| expect(input).not.toHaveAttribute('aria-invalid'); | ||
| } |
There was a problem hiding this comment.
I don't think this is the right way to do this. We should check that dates outside the min and max range are disabled.
| }); | ||
|
|
||
| // Test to ensure the component handles edge cases like `minDate` and `maxDate` correctly | ||
| it('handles edge cases gracefully', () => { |
There was a problem hiding this comment.
Suggested change
| it('handles edge cases gracefully', () => { | |
| it('disables dates that are outside the given min and max range', () => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
feat,fix, orchore, among others). See existing PR titles for inspiration.For changes to apps
If applicable
Summary
This PR includes unit tests for the DatePicker component as mentioned in this ticket (https://openmrs.atlassian.net/issues/O3-3853).
Screenshots
Related Issue
Other