Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

O3-3791: Dispensing: display instructions from DrugOrder.instructions… #116

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

mogoodrich
Copy link
Member

… when dispensing drugs

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

Screenshots

Related Issue

Other

@@ -135,7 +135,16 @@ export function initiateMedicationDispenseBody(
whenHandedOver: null,
dosageInstruction: [
{
text: medicationRequest.dosageInstruction[0].text,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is sort of ugly, I'd imagine there might be a better way to do this, but if it works, that's fine I guess.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's definitely more than sort of ugly, agreed.... I was hoping someone might have a "duh" better way to do it, but I can also take another stab before merging.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made this simpler.

Copy link
Member

@mseaton mseaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, though one comment

@mogoodrich mogoodrich merged commit 47cf3c0 into main Aug 15, 2024
4 checks passed
@mogoodrich mogoodrich deleted the O3-3791 branch August 15, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants