-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) Various UI mods #119
Conversation
required | ||
/> | ||
)} | ||
<Stack gap={5}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is for consistent spacing between the form elements.
</Layer> | ||
</div> | ||
)} | ||
{prescriptionsTableRows?.length > 0 && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the pagination container is hidden in the empty state.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @denniskigen !
It's hard for me to review with all the formatting changes, but I trust you... :)
Why all the formatting changes, is yarn lint not set up properly?
I think it mostly derives from the fact that we used to have prettier ignore most things that weren't Typescript files, and we've been changing things so that we use it to reformat Sass files as well. |
Ah, right, I'm seeing that now... thanks @denniskigen ! |
Requirements
Summary
This PR applies various UI refactors to the Medication Dispensing UI, including:
display: none
on the collapsedTableExpandedRow
).Prescription details
Allergies tile to account for plurals.Other changes include:
Screenshots
Before
After
Related Issue
Other