Skip to content

Commit

Permalink
(chore) Fixup e2e workflow
Browse files Browse the repository at this point in the history
  • Loading branch information
denniskigen committed Sep 17, 2024
1 parent b803bfb commit 22d7ff7
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 20 deletions.
25 changes: 6 additions & 19 deletions .github/workflows/e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,43 +29,30 @@ jobs:
with:
node-version: 18

<<<<<<< Updated upstream
- name: Cache dependencies
id: cache-dependencies
=======
- name: 💾 Cache dependencies
id: cache
>>>>>>> Stashed changes
id: cache-dependencies
uses: actions/cache@v4
with:
path: '**/node_modules'
key: ${{ runner.os }}-${{ hashFiles('**/yarn.lock') }}

<<<<<<< Updated upstream
- name: Install dependencies
- name: 📦 Install dependencies
if: steps.cache-dependencies.outputs.cache-hit != 'true'
run: yarn install --immutable

- name: Get installed Playwright version
- name: 🔍 Get installed Playwright version
id: playwright-version
run: echo "PLAYWRIGHT_VERSION=$(grep '@playwright/test@' yarn.lock | sed -n 's/.*npm:\([^":]*\).*/\1/p' | head -n 1)" >> $GITHUB_ENV

- name: Cache Playwright binaries
- name: 💾 Cache Playwright binaries
id: playwright-cache
uses: actions/cache@v4
with:
path: |
~/.cache/ms-playwright
key: ${{ runner.os }}-playwright-${{ env.PLAYWRIGHT_VERSION }}

- name: Install Playwright Browsers
=======
- name: 📦 Install dependencies
if: steps.cache.outputs.cache-hit != 'true'
run: yarn install --immutable

- name: 🎭 Install Playwright Browsers
>>>>>>> Stashed changes
run: npx playwright install chromium --with-deps
if: steps.playwright-cache.outputs.cache-hit != 'true'

Expand Down Expand Up @@ -100,13 +87,13 @@ jobs:
retention-days: 30
overwrite: true

- name: Capture Server Logs
- name: 📝 Capture Server Logs
if: always()
uses: jwalton/gh-docker-logs@v2
with:
dest: './logs'

- name: Upload Logs as Artifact
- name: 📦 Upload Logs as Artifact
uses: actions/upload-artifact@v4
if: always()
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/node.js.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
repo-token: ${{ secrets.GITHUB_TOKEN }}
server-token: ${{ env.TURBO_TOKEN }}

- name: 🧪 Run tests, lint and typechecking
- name: 🧪 Run tests, lint and type checks
run: yarn verify

- name: 🏗️ Run build
Expand Down

0 comments on commit 22d7ff7

Please sign in to comment.