Skip to content

Commit

Permalink
(refactor) Change parseInt to parseFloat
Browse files Browse the repository at this point in the history
  • Loading branch information
NethmiRodrigo committed Oct 8, 2024
1 parent 9b32636 commit 5d13b60
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
8 changes: 4 additions & 4 deletions src/components/interactive-builder/add-question.modal.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -486,9 +486,9 @@ const AddQuestionModal: React.FC<AddQuestionModalProps> = ({
id="min"
labelText="Min"
value={min || ''}
invalid={parseInt(min) > parseInt(max)}
invalid={parseFloat(min) > parseFloat(max)}
invalidText={
parseInt(min) > parseInt(max)
parseFloat(min) > parseFloat(max)
? t('invalidMinMax', 'Min value cannot be greater than max')
: ''
}
Expand All @@ -499,9 +499,9 @@ const AddQuestionModal: React.FC<AddQuestionModalProps> = ({
id="max"
labelText="Max"
value={max || ''}
invalid={parseInt(min) > parseInt(max)}
invalid={parseFloat(min) > parseFloat(max)}
invalidText={
parseInt(min) > parseInt(max)
parseFloat(min) > parseFloat(max)
? t('invalidMinMax', 'Min value cannot be greater than max')
: ''
}
Expand Down
8 changes: 4 additions & 4 deletions src/components/interactive-builder/edit-question.modal.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -454,9 +454,9 @@ const EditQuestionModal: React.FC<EditQuestionModalProps> = ({
id="min"
labelText="Min"
value={min || ''}
invalid={parseInt(min) > parseInt(max)}
invalid={parseFloat(min) > parseFloat(max)}
invalidText={
parseInt(min) > parseInt(max) ? t('invalidMinMax', 'Min value cannot be greater than max') : ''
parseFloat(min) > parseFloat(max) ? t('invalidMinMax', 'Min value cannot be greater than max') : ''
}
onChange={(event: React.ChangeEvent<HTMLInputElement>) => setMin(event.target.value)}
required
Expand All @@ -465,9 +465,9 @@ const EditQuestionModal: React.FC<EditQuestionModalProps> = ({
id="max"
labelText="Max"
value={max || ''}
invalid={parseInt(min) > parseInt(max)}
invalid={parseFloat(min) > parseFloat(max)}
invalidText={
parseInt(min) > parseInt(max) ? t('invalidMinMax', 'Min value cannot be greater than max') : ''
parseFloat(min) > parseFloat(max) ? t('invalidMinMax', 'Min value cannot be greater than max') : ''
}
onChange={(event: React.ChangeEvent<HTMLInputElement>) => setMax(event.target.value)}
required
Expand Down

0 comments on commit 5d13b60

Please sign in to comment.