(fix) More fixes to the save form workflow #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denniskigen
force-pushed
the
fix/save-workflow
branch
from
ca531cb
to
714a5d7
Compare
|
Size Change: +28 B (0%) Total Size: 2.93 MB
ℹ️ View Unchanged
|
mogoodrich
approved these changes
Aug 9, 2023
There was a problem hiding this comment.
Thanks @denniskigen ! I still haven't gotten deep enough into this to do a detailed review, but functionality LGTM!
arodidev
pushed a commit
to arodidev/openmrs-esm-form-builder
that referenced
this pull request
Aug 14, 2023
commit 3315b3a Author: arodidev <[email protected]> Date: Mon Aug 14 13:32:46 2023 +0300 Moved validation state to parent component commit 17df8c4 Author: arodidev <[email protected]> Date: Fri Aug 11 13:53:57 2023 +0300 feat/schema-validator: UX changes commit fddb910 Author: arodidev <[email protected]> Date: Fri Aug 11 08:41:25 2023 +0300 feat/schema-validator: datatype-control checking through config commit 73a0d1b Merge: c8aee01 6f526b7 Author: arodidev <[email protected]> Date: Thu Aug 10 10:40:42 2023 +0300 Merge branch 'feat/schema-validator' of https://github.com/arodidev/openmrs-esm-form-builder into feat/schema-validator commit c8aee01 Author: arodidev <[email protected]> Date: Thu Aug 10 10:40:35 2023 +0300 feat/schema-validator: refactoring error responses commit 6f526b7 Merge: 499b35d 301aabc Author: Jamie Arodi <[email protected]> Date: Thu Aug 10 08:33:42 2023 +0300 Merge branch 'main' into feat/schema-validator commit 301aabc Author: Dennis Kigen <[email protected]> Date: Wed Aug 9 14:57:22 2023 -0700 (fix) More fixes to the save form workflow (openmrs#175) commit a4d2a64 Author: Dennis Kigen <[email protected]> Date: Wed Aug 9 07:23:09 2023 -0700 (feat) Tweak editor action button behaviour (openmrs#174) commit 499b35d Author: arodidev <[email protected]> Date: Wed Aug 9 13:49:16 2023 +0300 feat/schema-validator: update yarn.lock error commit d237b3b Author: arodidev <[email protected]> Date: Tue Aug 8 15:23:28 2023 +0300 feat/schema-validator: added checking for answers and resolutionType commit 6dc91e3 Author: arodidev <[email protected]> Date: Fri Aug 4 15:17:50 2023 +0300 clean up commit 5826290 Merge: 3e556d1 dde0e4b Author: arodidev <[email protected]> Date: Fri Aug 4 15:10:06 2023 +0300 Merge branch 'main' into feat/schema-validator commit 3e556d1 Author: arodidev <[email protected]> Date: Fri Aug 4 14:02:33 2023 +0300 schema-validator: updated separation of concerns commit 5e75063 Merge: 53aa420 fcb8732 Author: Jamie Arodi <[email protected]> Date: Tue Aug 1 13:59:21 2023 +0300 Merge branch 'main' into feat/schema-validator commit 53aa420 Author: arodidev <[email protected]> Date: Tue Aug 1 13:28:19 2023 +0300 schema-validator: clean up commit 211fc5b Author: arodidev <[email protected]> Date: Tue Aug 1 13:23:22 2023 +0300 schema-validator: added functionality for obsGroup checking commit c188aa6 Author: arodidev <[email protected]> Date: Mon Jul 31 14:52:47 2023 +0300 schema-validator: clean up commit 056fec9 Author: arodidev <[email protected]> Date: Mon Jul 31 14:41:04 2023 +0300 schema-validator: added mappings commit dc5e641 Author: arodidev <[email protected]> Date: Wed Jul 19 22:29:40 2023 +0300 schema-validator: clears state for new validation objects commit a28c3a3 Author: arodidev <[email protected]> Date: Wed Jul 19 18:51:39 2023 +0300 schema-validator: formatting changes and minor improvements commit 3b63fd6 Author: arodidev <[email protected]> Date: Tue Jul 18 18:15:24 2023 +0300 schema-validator: updated response message commit 230ce69 Author: arodidev <[email protected]> Date: Tue Jul 18 16:24:55 2023 +0300 schema-validator: First working demo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR makes some fixes to the save form workflow. Specifically, it makes it possible for changes made to the schema editor to get picked up by the save form modal and vice versa.
Video
save-workflow.mp4
Related Issue
https://issues.openmrs.org/browse/O3-2124