Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feat) Updated concept datatype for the schema validator #337

Merged
merged 2 commits into from
Aug 14, 2024
Merged

(feat) Updated concept datatype for the schema validator #337

merged 2 commits into from
Aug 14, 2024

Conversation

Art-Ndiema
Copy link
Contributor

@Art-Ndiema Art-Ndiema commented Aug 8, 2024 •
edited
Loading

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

The datatypeToRenderingMap has been updated within the schema validator, in form builder to giving it more context as to the concept datatypes returned from the backend and the supported rendering types for these concepts.

Screenshots

Related Issue

Other

@arodidev @CynthiaKamau @hadijahkyampeire feel free to review this. Thanks : )

arodidev
arodidev approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@arodidev arodidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @Art-Ndiema

hadijahkyampeire
hadijahkyampeire approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@hadijahkyampeire hadijahkyampeire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Art-Ndiema

@denniskigen denniskigen changed the title Updated concept datatype for the schema validator (feat) Updated concept datatype for the schema validator Aug 8, 2024
@arodidev arodidev merged commit cca7bb8 into openmrs:main Aug 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hadijahkyampeire hadijahkyampeire hadijahkyampeire approved these changes

@arodidev arodidev arodidev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Art-Ndiema @hadijahkyampeire @arodidev