Added toggle Render type to interactive builder #349
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks @Kinotijoan , please do the same for the edit-question.modal
Sure, I will |
There was a problem hiding this comment.
Thanks @Kinotijoan! Just some minor corrections related to translation strings
| /> | ||
| <TextInput | ||
| id="lableFalse" | ||
| labelText={t('Label false', 'Lable false')} |
There was a problem hiding this comment.
Suggested change
| labelText={t('Label false', 'Lable false')} | |
| labelText={t('labelFalse', 'Label false')} |
| <div> | ||
| <TextInput | ||
| id="lableTrue" | ||
| labelText={t('Label true', 'Label true')} |
There was a problem hiding this comment.
Suggested change
| labelText={t('Label true', 'Label true')} | |
| labelText={t('labelTrue', 'Label true')} |
| labelText={t('Label false', 'Lable false')} | ||
| value={t(toggleLabelFalse || '')} | ||
| onChange={(event: React.ChangeEvent<HTMLInputElement>) => setToggleLabelFalse(event.target.value)} | ||
| placeholder={t('Off')} |
There was a problem hiding this comment.
Suggested change
| placeholder={t('Off')} | |
| placeholder={t("off", "Off")} |
| labelText={t('Label true', 'Label true')} | ||
| value={t(toggleLabelTrue || '')} | ||
| onChange={(event: React.ChangeEvent<HTMLInputElement>) => setToggleLabelTrue(event.target.value)} | ||
| placeholder={t('On')} |
There was a problem hiding this comment.
Suggested change
| placeholder={t('On')} | |
| placeholder={t("on", "On")} |
|
@Kinotijoan could you please update the PR description with the PR template, it helps the reviewers have more context on the great work you've done 😊 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.