(refactor) Clean up hooks (#445)

This PR cleans up the hooks directory, removing unused hooks and renaming others to match the `.ts` extension for consistency. `.tsx` should be reserved for components that contain JSX.

src/components/inputs/ui-select-extended/ui-select-extended.test.tsx

@@ -14,7 +14,6 @@ const mockUsePatient = jest.mocked(usePatient);
 const mockUseSession = jest.mocked(useSession);
 global.ResizeObserver = require('resize-observer-polyfill');
 
-jest.mock('../../../hooks/useRestMaxResultsCount', () => jest.fn().mockReturnValue({ systemSetting: { value: '50' } }));
 jest.mock('lodash-es/debounce', () => jest.fn((fn) => fn));
 
 jest.mock('lodash-es', () => ({

src/form-engine.test.tsx

@@ -92,7 +92,6 @@ jest.mock('../src/api', () => {
   };
 });
 
-jest.mock('./hooks/useRestMaxResultsCount', () => jest.fn().mockReturnValue({ systemSetting: { value: '50' } }));
 jest.mock('./hooks/useEncounterRole', () => ({
   useEncounterRole: jest.fn().mockReturnValue({
     isLoading: false,

src/hooks/useConcepts.tsx → src/hooks/useConcepts.ts

@@ -1,6 +1,6 @@
 import { useMemo } from 'react';
-import { type FetchResponse, type OpenmrsResource, openmrsFetch, restBaseUrl } from '@openmrs/esm-framework';
 import useSWRInfinite from 'swr/infinite';
+import { type FetchResponse, type OpenmrsResource, openmrsFetch, restBaseUrl } from '@openmrs/esm-framework';
 
 type ConceptFetchResponse = FetchResponse<{ results: Array<OpenmrsResource> }>;
 
@@ -12,7 +12,6 @@ export function useConcepts(references: Set<string>): {
   isLoading: boolean;
   error: Error | undefined;
 } {
-
   const chunkSize = 100;
   const totalCount = references.size;
   const totalPages = Math.ceil(totalCount / chunkSize);

src/hooks/useDataSourceDependentValue.ts

@@ -1,6 +1,6 @@
+import { useWatch } from 'react-hook-form';
 import { type FormField } from '../types';
 import { useFormProviderContext } from '../provider/form-provider';
-import { useWatch } from 'react-hook-form';
 
 const useDataSourceDependentValue = (field: FormField) => {
   const dependentField = field.questionOptions['config']?.referencedField;

src/hooks/useEncounterRole.tsx → src/hooks/useEncounterRole.ts

@@ -1,5 +1,5 @@
-import { type OpenmrsResource, openmrsFetch, restBaseUrl } from '@openmrs/esm-framework';
 import useSWRImmutable from 'swr/immutable';
+import { type OpenmrsResource, openmrsFetch, restBaseUrl } from '@openmrs/esm-framework';
 
 export function useEncounterRole() {
   const { data, error, isLoading } = useSWRImmutable<{ data: { results: Array<OpenmrsResource> } }, Error>(

src/hooks/useFormCollapse.tsx → src/hooks/useFormCollapse.ts

@@ -1,5 +1,5 @@
-import type { FormExpanded, SessionMode } from '../types';
 import { useCallback, useEffect, useState } from 'react';
+import type { FormExpanded, SessionMode } from '../types';
 
 export function useFormCollapse(sessionMode: SessionMode) {
   const [isFormExpanded, setIsFormExpanded] = useState<FormExpanded>(undefined);

src/hooks/useFormJson.tsx → src/hooks/useFormJson.ts

@@ -9,6 +9,7 @@ import { moduleName } from '../globals';
 export function useFormJson(formUuid: string, rawFormJson: any, encounterUuid: string, formSessionIntent: string) {
   const [formJson, setFormJson] = useState<FormSchema>(null);
   const [error, setError] = useState(validateFormsArgs(formUuid, rawFormJson));
+
   useEffect(() => {
     const setFormJsonWithTranslations = (formJson: FormSchema) => {
       if (formJson?.translations) {
@@ -17,6 +18,7 @@ export function useFormJson(formUuid: string, rawFormJson: any, encounterUuid: s
       }
       setFormJson(formJson);
     };
+
     loadFormJson(formUuid, rawFormJson, formSessionIntent)
       .then((formJson) => {
         setFormJsonWithTranslations({ ...formJson, encounter: encounterUuid });

src/hooks/usePatientData.tsx → src/hooks/usePatientData.ts

@@ -24,7 +24,7 @@ const patientGenderMap = {
 export const usePatientData = (patientUuid) => {
   const { patient, isLoading: isLoadingPatient, error: patientError } = usePatient(patientUuid);
   if (patient && !isLoadingPatient) {
-    // This is to support backward compatibility with the AMPATH JSON format
+    // This is for backward compatibility with the Angular form engine
     patient['age'] = calculateAge(new Date(patient?.birthDate));
     patient['sex'] = patientGenderMap[patient.gender] ?? 'U';
   }