Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) O3-3682 - Refactor File Picker Component and Fix Multiple Selection Support #431

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

suubi-joshua
Copy link

@suubi-joshua suubi-joshua commented Nov 25, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR refactors the file picker component in the form engine to align with standard input design and improve functionality. The handleFilePickerChange function now supports multiple file selections, allowing users to upload multiple files by appending them to the existing value using the field.questionOptions.allowMultiple configuration. The component also displays previews for all selected files, integrates camera capture functionality with live preview and upload options, and addresses previous limitations in file selection and usability, ensuring a consistent and enhanced user experience.

Screenshots

Screencast.from.27-11-24.18.06.45.webm

Related Issue

https://openmrs.atlassian.net/browse/O3-3682

Other

@samuelmale
Copy link
Member

Thanks for the PR @suubi-joshua! Just a couple of concerns:

  1. Can you attach screenshots or a short video as a visual aid for the reviewers?
  2. Can you add unit tests for your changes?

@suubi-joshua
Copy link
Author

Thanks for the PR @suubi-joshua! Just a couple of concerns:

1. Can you attach screenshots or a short video as a visual aid for the reviewers?

2. Can you add unit tests for your changes?

@samuelmale I made some changes and added that video. Remaining with unit test.

@suubi-joshua
Copy link
Author

@samuelmale should the uploads from the file components show up in the attachments preview section?

@samuelmale
Copy link
Member

samuelmale commented Dec 18, 2024

should the uploads from the file components show up in the attachments preview section?

@suubi-joshua By attachments preview section do you mean the "Attachments dashboard" on the patient chart? If so, yes! and I believe that's already working.

If you meant a backed-in preview (within the form) on file selection; Yes! Right now, there is no preview of the uploaded file. In a context where we have multiple selections, we can't preview all the selected files at once; we could do something like:

Screenshot 2024-12-18 at 23 08 19

Alternatively, we could seek UX advisory


Generally, we need to refine the UX of our file picker for more practicality.

@suubi-joshua
Copy link
Author

@samuelmale thanks for that clarification, I needed clarification on both previews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants