(chore) Bump @carbon/react to v1.71.0 #435
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirupius
reviewed
Dec 3, 2024
| @@ -29,7 +29,7 @@ | |||
| "access": "public" | |||
| }, | |||
| "dependencies": { | |||
| "@carbon/react": ">1.47.0 <1.50.0", | |||
There was a problem hiding this comment.
Hi @elishabantana there's an ongoing discussion to make this a peer dependency all together. The reason it was previously like this was because of Carbon's searchable multi-select behavior between versions.
We also wouldn't want to give a static version because this is package is only a library and not a microfrontend
There was a problem hiding this comment.
@pirupius sorry I'm a bit lost. Does that mean we shouldn't update carbon or we should update it to be a more up-to-date range?
There was a problem hiding this comment.
@NethmiRodrigo The reason this was added was to resolve a breaking change in some components. The resolution would involve
- Testing and fixing any breaking changes in some components with newer versions Carbon
- Move carbon back to being a peer dependency.
|
So how do I bump its carbon version to the latest
…On Tue, Dec 3, 2024, 15:41 Pius Rubangakene ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In package.json
<#435 (comment)>
:
> @@ -29,7 +29,7 @@
"access": "public"
},
"dependencies": {
- ***@***.***/react": ">1.47.0 <1.50.0",
Hi @elishabantana <https://github.com/elishabantana> there's an ongoing
discussion to make this a peer dependency all together. The reason it was
previously like this was because of Carbon's searchable multi-select
behavior between versions.
We also wouldn't want to give a static version because this is package is
only a library and not a microfrontend
—
Reply to this email directly, view it on GitHub
<#435 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIRFYDWCTXMGGOMW26GQ4UD2DWRJLAVCNFSM6AAAAABS3QKBOWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDINZVGU3TEMZZHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR updated the version of @carbon/react to the latest, v1.71.0 in esm-form-engine-lib.
Screenshots
Related Issue
https://openmrs.atlassian.net/browse/O3-4229
Other