(refactor) Refactor usePatientPrograms hook to use SWR #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denniskigen
force-pushed
the
refactor/use-patient-programs-hook
branch
from
c255b13 to
e9e89b7
Compare
|
Size Change: -200 kB (-13.64%) 👏 Total Size: 1.27 MB
ℹ️ View Unchanged
|
Refactors the usePatientProgram hook to leverage an SWR hook for fetching patient programs. With this, we get: - Automatic caching and revalidation - Conditional fetching based on the patientUuid and the `formJson.meta.programs.hasProgramFields` property of the form - Built-in error and loading states - Better handling of race conditions
denniskigen
force-pushed
the
refactor/use-patient-programs-hook
branch
from
e9e89b7 to
b020b22
Compare
samuelmale
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Nice one @denniskigen! We need to refactor all data fetching hooks to use SWR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Refactors the usePatientProgram hook to leverage an SWR hook for fetching patient programs. With this, we get:
formJson.meta.programs.hasProgramFieldsproperty of the formScreenshots
Related Issue
Other
What's a good test plan for this, @samuelmale? I've tweaked @CynthiaKamau's sample schema from this PR and amended to include a truthy
meta.programs.hasProgramFieldsvalue to get the hook to run. I get active enrollments back as evidenced by the console.log in this screenshot:Is there a more thorough way to test this?