Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) O3-4253: Update the name property of the home dashboard link meta #232

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

vasharma05
Copy link
Member

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR updates the name property of the home page dashboard slot, since the translations are present for the key home and not for the key Home and hence the respective title on the dashboard metrics wasn't getting translated.

Screenshots

Before

image

After

image

Related issue

https://issues.openmrs.org/browse/O3-4253

Other

Copy link
Contributor

Size Change: 0 B

Total Size: 375 kB

ℹ️ View Unchanged
Filename Size
packages/esm-home-app/dist/132.js 175 B
packages/esm-home-app/dist/146.js 135 B
packages/esm-home-app/dist/173.js 135 B
packages/esm-home-app/dist/197.js 135 B
packages/esm-home-app/dist/214.js 142 B
packages/esm-home-app/dist/241.js 135 B
packages/esm-home-app/dist/271.js 725 B
packages/esm-home-app/dist/294.js 135 B
packages/esm-home-app/dist/300.js 135 B
packages/esm-home-app/dist/335.js 144 B
packages/esm-home-app/dist/367.js 317 kB
packages/esm-home-app/dist/41.js 2.62 kB
packages/esm-home-app/dist/438.js 1.49 kB
packages/esm-home-app/dist/442.js 135 B
packages/esm-home-app/dist/538.js 135 B
packages/esm-home-app/dist/55.js 135 B
packages/esm-home-app/dist/618.js 135 B
packages/esm-home-app/dist/652.js 138 B
packages/esm-home-app/dist/661.js 138 B
packages/esm-home-app/dist/679.js 160 B
packages/esm-home-app/dist/690.js 135 B
packages/esm-home-app/dist/723.js 134 B
packages/esm-home-app/dist/783.js 8.01 kB
packages/esm-home-app/dist/840.js 135 B
packages/esm-home-app/dist/859.js 135 B
packages/esm-home-app/dist/879.js 138 B
packages/esm-home-app/dist/900.js 133 B
packages/esm-home-app/dist/903.js 5.73 kB
packages/esm-home-app/dist/913.js 22.1 kB
packages/esm-home-app/dist/944.js 134 B
packages/esm-home-app/dist/99.js 134 B
packages/esm-home-app/dist/main.js 10.5 kB
packages/esm-home-app/dist/openmrs-esm-home-app.js 3.31 kB

compressed-size-action

@vasharma05
Copy link
Member Author

Hi @denniskigen!
Requesting your review here.
Thanks!

Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @vasharma05!

@denniskigen denniskigen merged commit 6c8fd82 into main Dec 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants