Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/O3-3515: Add user & timestamp to the Printed patient identifier sticker #2060

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jwnasambu
Copy link
Contributor

@jwnasambu jwnasambu commented Oct 10, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

I added a user & timestamp so that the patient identifier sticker can display who has printed when and what time.

Screenshots

screencast.2024-10-15.7.PM-07-52.mp4

Related Issue

https://openmrs.atlassian.net/browse/O3-3515

Other

@jwnasambu jwnasambu force-pushed the O3-3515 branch 4 times, most recently from cb7f3f0 to 994ae22 Compare October 15, 2024 16:03
@jwnasambu
Copy link
Contributor Author

@michaelbontyes, @jnsereko, @ibacher, @paul Adams, and @Ciarán Duffy
kindly help me review this PR at your convenience. I have no design and am unsure if my changes meet the requirements.

Copy link
Contributor

@jnsereko jnsereko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @jwnasambu for working on this
All look good except the code formatting

Comment on lines 86 to 97
@page {
size: ${pageSize};
}
`}
@page {
size: ${pageSize};
}
`}
Copy link
Contributor

@jnsereko jnsereko Oct 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kindly fix this formatting issue

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jnsereko Thanks for the review. I have fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants