(feat) Add 'ward-patient' group to the order basket related workspaces #2130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @brandones @ibacher @chibongho, |
vasharma05
force-pushed
the
feat/add-order-basket-to-ward
branch
from
b019a98 to
603732f
Compare
|
Size Change: -44.6 kB (-0.28%) Total Size: 16 MB
ℹ️ View Unchanged
|
|
Any reason why the build job is failing during the Thanks! |
No So, solution-wise, I don't think what we're doing in this PR is sustainable. We need a way of the ward app to be able to declare that these are the workspaces that it's using. This suggests to me that we need to reconsider being able to set the group during the call to launch workspace or some other mechanism that doesn't require modifying the workspace registration. |
If we pass the group name in the |
vasharma05
force-pushed
the
feat/add-order-basket-to-ward
branch
from
603732f to
1260a00
Compare
|
Well, passing it to It may be that we need to modify the |
We don't have to, because as per the design and confirmed with Paul, only one workspace group can be opened at a time. Also, the
Yes, this was also suggested by @usamaidrsk. However, the drawback is that whenever I want to add a workspace to a workspace group, I have to go to the workspace group's registration and update it. But why does the workspace group need to handle this scenario? In-case someone builds on top of the ward app, they will have to come to the ref app and define their workspace in the workspace group's registration. My question is why does the workspace group need to know about all the workspaces defined for that group, and if it wants the information, the opened workspace stores the currentWorkspaceGroup info, so that is also convenient. I hope I answered your questions |
|
Right now, I have a scenario where I want to include the patient search workspace from patient-search-app in a new workspace group I think this is contrary to the separation of concern design pattern that extensions / workspaces system otherwise gives us.
|
|
Right @vasharma05 at the end of the day I think this PR, as @chibongho points out, demonstrates a violation of our design principles. So we have to tweak the workspace groups system so that we can have a proper separation of concerns. The patient chart should not need to know about the existence of the ward app for any reason. |
|
Yes, @chibongho, you need to add the @brandones @ibacher, let me work on defining workspace groups more explicitly as you have discussed. |
|
Hi @ibacher @brandones, |
vasharma05
force-pushed
the
feat/add-order-basket-to-ward
branch
from
366c5d1 to
005e735
Compare
|
@vasharma05 the build and e2e tests are failing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR adds the necessary changes to add the order basket to the ward app:
ward-patientgroup name to the order basket related workspaces registrationScreenshots
Screen.Recording.2024-12-12.at.17.46.54.mov
Related Issue
None
Other
Depends on openmrs/openmrs-esm-core#1185