(fix) Restore generic patient widget #2139
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -1 B (0%) Total Size: 15.9 MB ℹ️ View Unchanged
|
4 tasks
|
Good catch, Ian. But I think we actually do want to provide this as an extension config? Looking at the config schema, all of that appears to be specific to a particular widget. I guess it's mostly academic right now since, with only one extension, the behavior will be the same. But that's my thought. |
|
My thinking here is that although it's a config schema for a specific widget, that widget is the only public extension, so all copies of the extension have a shared schema, even though they should have different schema instances. I guess alternatively we can switch to |
yeah that's what I was thinking; and then when one day we have another generic widget it will be clearer how to add its config |
denniskigen
approved these changes
Dec 6, 2024
|
Huh... so it looks like |
|
Should we close this out? @ibacher, @vasharma05? |
No, but I'll turn it into a draft. We need to fix the config system so that this works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This fixes the generic-patient-widgets app. The functionality was broken in openmrs/openmrs-esm-core#898, which was solving an issue related to configurations being provided before their schema was loaded. Inadvertently, this requires apps to call
defineConfigSchema()is they use configuration anywhere.The generic-patient-widgets-app was using
defineExtensionConfigSchema(), and using this call wrongly (since it passed the module name instead of the extension name). The goal of this function is to allow individual extensions to have config schemas separate from those that are in the app they define, not to provide the configuration schema for the module.Screenshots
Related Issue
Other