(fix) O3-3787 : Refresh workspace title when clicked on new patient #1341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chibongho
approved these changes
Oct 11, 2024
Thanks @chibongho . |
|
I think this is the correct way to solve the problem. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
I have mentioned detailed solution in this PR. For now this might be like a temporary solution.
The workspace title which was set dynamically does not updated when clicked on other patients.Putting the props which are passed to the title node as a dependency in useEffect works.
OpenMRS - Personal - Microsoft_ Edge 2024-10-10 21-26-09.webm
Related Issue
https://openmrs.atlassian.net/browse/O3-3787